Issue metadata
Sign in to add a comment
|
Migrate ios/chrome/browser/reading_list/reading_list_download_service.h to use net::NetworkChangeNotifier::NetworkChangeObserver |
||||||||||||||||||||||
Issue descriptionnet::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate ios/chrome/browser/reading_list/reading_list_download_service.h to use NetworkChangeObserver instead. See Issue 754695 for the motivation.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07e6f0383450956d781d19a6a7ef37a51f30e415 commit 07e6f0383450956d781d19a6a7ef37a51f30e415 Author: Minjeong Lee <apenr1234@gmail.com> Date: Fri Nov 10 16:43:06 2017 Migrate ConnectionTypeObserver to NetworkChangeObserver in reading_list_download_service.h Bug: 780480 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibf90fcc96e61c935f83a56da9d257e78fd102648 Reviewed-on: https://chromium-review.googlesource.com/754643 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515570} [modify] https://crrev.com/07e6f0383450956d781d19a6a7ef37a51f30e415/AUTHORS [modify] https://crrev.com/07e6f0383450956d781d19a6a7ef37a51f30e415/ios/chrome/browser/reading_list/reading_list_download_service.cc [modify] https://crrev.com/07e6f0383450956d781d19a6a7ef37a51f30e415/ios/chrome/browser/reading_list/reading_list_download_service.h
,
Nov 10 2017
Thanks, apenr1234@! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by laforge@google.com
, Nov 7 2017