For autofill fields, if they are marked as 'fill-only-when-focus' field, and they are not currently the focus, we should not fill them automatically.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8535eae19ab4b5188bd0e3143368f35f6d903cc2 commit 8535eae19ab4b5188bd0e3143368f35f6d903cc2 Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Mon Nov 13 16:25:09 2017 [Autofill] Implement only_fill_when_focused feature. For autofill fields marked as only_fill_when_focused, stop filling them unless they are the focused field. This is used to prevent filling multiple phone numbers in the same form so far, but might be used for other fields going forward. Bug: 780471 Change-Id: I517125c549b4a52daf7141080c33981484af4494 Reviewed-on: https://chromium-review.googlesource.com/744703 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515955} [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/chrome/browser/autofill/autofill_interactive_uitest.cc [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/chrome/test/data/autofill/form_phones.html [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/8535eae19ab4b5188bd0e3143368f35f6d903cc2/components/autofill/core/browser/form_structure.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc64b1d9198230786c2976fb54618bbdab33409a commit bc64b1d9198230786c2976fb54618bbdab33409a Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Mon Dec 11 19:35:30 2017 [Autofill] Change autofill metrics to log correctly for rationalized phone fields. After a phone number field is marked as fill_only_when_focused by rationalization, we should log the quality metrics differently compared to normal fields. For example, if a field is left empty and being fill_only_when_focused, it should be logged as true negative, meaning we anticipated this field will be left empty. Bug: 780471 Change-Id: I3457b6381430055c7c4cb8431f0da193f396065d Reviewed-on: https://chromium-review.googlesource.com/786340 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#523172} [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/tools/metrics/histograms/enums.xml [modify] https://crrev.com/bc64b1d9198230786c2976fb54618bbdab33409a/tools/metrics/histograms/histograms.xml
Comment 1 by wuandy@chromium.org
, Nov 1 2017Owner: wuandy@chromium.org
Summary: [autofill]Implement fill-only-when-focus feature for autofill fields. (was: Implement fill-only-when-focus feature for autofill fields.)