New issue
Advanced search Search tips

Issue 780470 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 754695



Sign in to add a comment

Migrate content/browser/renderer_host/p2p/socket_dispatcher_host.h to use net::NetworkChangeNotifier::NetworkChangeObserver

Project Member Reported by xunji...@chromium.org, Nov 1 2017

Issue description

net::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate content/browser/renderer_host/p2p/socket_dispatcher_host.h to use NetworkChangeObserver instead. 

See  Issue 754695  for the motivation.
 
 
I would like to work on this.

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/052b26853559e3e89e82fbc8184eb54e51159bea

commit 052b26853559e3e89e82fbc8184eb54e51159bea
Author: mallikarjun82 <vm.arjun@samsung.com>
Date: Thu Nov 16 19:40:43 2017

Change IPAddressObserver to NetworkChangeObserver

This CL migrates socket_dispatcher_host.h to use NetworkChangeObserver.
More details are in the following bug

Bug:  780470 
Change-Id: If48f749c81272d32bfcee84ea5f5b5639157f5a0
Reviewed-on: https://chromium-review.googlesource.com/754765
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517154}
[modify] https://crrev.com/052b26853559e3e89e82fbc8184eb54e51159bea/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/052b26853559e3e89e82fbc8184eb54e51159bea/content/browser/renderer_host/p2p/socket_dispatcher_host.h

Status: Fixed (was: Available)

Sign in to add a comment