Issue metadata
Sign in to add a comment
|
Migrate jingle/notifier/communicator/login.h to use net::NetworkChangeNotifier::NetworkChangeObserver |
||||||||||||||||||||||
Issue descriptionnet::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate jingle/notifier/communicator/login.h to use NetworkChangeObserver instead. See Issue 754695 for the motivation.
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 9 2017
I would like to work on this.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b499815db9d30fce1d22542ecc903a4522f6f2 commit e6b499815db9d30fce1d22542ecc903a4522f6f2 Author: mck.giri <mck.giri@samsung.com> Date: Wed Nov 29 08:30:39 2017 Change IPAddressObserver and ConnectionTypeObserver to NetworkChangeObserver This CL migrates jingle/notifier/communicator/login.h to use NetworkChangeObserver. Bug: 780469 Change-Id: Ic3ccfe9c5bc6031550cd8297f22fd2521fad62b0 Reviewed-on: https://chromium-review.googlesource.com/773767 Commit-Queue: Mu Ven <sataya.m@samsung.com> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#520045} [modify] https://crrev.com/e6b499815db9d30fce1d22542ecc903a4522f6f2/AUTHORS [modify] https://crrev.com/e6b499815db9d30fce1d22542ecc903a4522f6f2/jingle/notifier/communicator/login.cc [modify] https://crrev.com/e6b499815db9d30fce1d22542ecc903a4522f6f2/jingle/notifier/communicator/login.h
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d881009f408955cc404a75b6aad86151ca0fd97c commit d881009f408955cc404a75b6aad86151ca0fd97c Author: mck.giri <mck.giri@samsung.com> Date: Wed Dec 06 05:31:04 2017 Do not attempt reconnect if connection type is NONE. Observers performing constructive activities like trying to establish a connection to a server should only do so when the |type != CONNECTION_NONE|. Without checking |type| reconnect attempts may waste resources and get terminated with ERR_NETWORK_CHANGED. Bug: 780469 Change-Id: Iba5b734a007a58de93571f67004614788df0e393 Reviewed-on: https://chromium-review.googlesource.com/808547 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522017} [modify] https://crrev.com/d881009f408955cc404a75b6aad86151ca0fd97c/jingle/notifier/communicator/login.cc
,
Dec 6 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by laforge@google.com
, Nov 7 2017