Issue metadata
Sign in to add a comment
|
Migrate content/browser/ppapi_plugin_process_host.cc to use net::NetworkChangeNotifier::NetworkChangeObserver |
||||||||||||||||||||||||
Issue descriptionnet::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate content/browser/ppapi_plugin_process_host.cc to use NetworkChangeObserver instead. See Issue 754695 for the motivation.
,
Nov 2 2017
Hi! I want to solve this as my first bug. I wanted to know if there is any issue if I do that. Thanks!
,
Nov 2 2017
I don't imagine there is any. Please feel free to take this! The guide to submit your first patch is at https://www.chromium.org/developers/contributing-code.
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b93d91d912066c3acde66c3215634da27dc50722 commit b93d91d912066c3acde66c3215634da27dc50722 Author: Juan Jose Lopez Jaimez <jj.lopezjaimez@gmail.com> Date: Fri Nov 03 21:05:52 2017 Migrate content/browser/ppapi_plugin_process_host.cc to use NetworkChangeObserver Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=780468 Change-Id: I68acba99dbeeb5e14422718efcc14a9ab1bdd919 Reviewed-on: https://chromium-review.googlesource.com/752557 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513907} [modify] https://crrev.com/b93d91d912066c3acde66c3215634da27dc50722/AUTHORS [modify] https://crrev.com/b93d91d912066c3acde66c3215634da27dc50722/content/browser/ppapi_plugin_process_host.cc
,
Nov 3 2017
Closing this issue. This is fixed by jj.lopezjaimez@gmail.com.
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Nov 1 2017