New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780468 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 754695



Sign in to add a comment

Migrate content/browser/ppapi_plugin_process_host.cc to use net::NetworkChangeNotifier::NetworkChangeObserver

Project Member Reported by xunji...@chromium.org, Nov 1 2017

Issue description

net::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate content/browser/ppapi_plugin_process_host.cc to use NetworkChangeObserver instead. 

See  Issue 754695  for the motivation.
 
Labels: Hotlist-GoodFirstBug
Hi!

I want to solve this as my first bug. I wanted to know if there is any issue if I do that.

Thanks!
I don't imagine there is any. Please feel free to take this!
The guide to submit your first patch is at https://www.chromium.org/developers/contributing-code. 

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93d91d912066c3acde66c3215634da27dc50722

commit b93d91d912066c3acde66c3215634da27dc50722
Author: Juan Jose Lopez Jaimez <jj.lopezjaimez@gmail.com>
Date: Fri Nov 03 21:05:52 2017

Migrate content/browser/ppapi_plugin_process_host.cc to use NetworkChangeObserver


Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=780468
Change-Id: I68acba99dbeeb5e14422718efcc14a9ab1bdd919
Reviewed-on: https://chromium-review.googlesource.com/752557
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513907}
[modify] https://crrev.com/b93d91d912066c3acde66c3215634da27dc50722/AUTHORS
[modify] https://crrev.com/b93d91d912066c3acde66c3215634da27dc50722/content/browser/ppapi_plugin_process_host.cc

Cc: jj.lopez...@gmail.com
Status: Fixed (was: Available)
Closing this issue. This is fixed by jj.lopezjaimez@gmail.com.

Comment 6 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment