New issue
Advanced search Search tips

Issue 780467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 754695



Sign in to add a comment

Migrate remoting/host/signaling_connector.h to use net::NetworkChangeNotifier::NetworkChangeObserver

Project Member Reported by xunji...@chromium.org, Nov 1 2017

Issue description

net::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate remoting/host/signaling_connector.h to use NetworkChangeObserver instead. 

See  Issue 754695  for the motivation.
 

Comment 1 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 2 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb123ecd4b5fc4c1ad81ff075fa7d4aff8e90908

commit bb123ecd4b5fc4c1ad81ff075fa7d4aff8e90908
Author: Minjeong Lee <apenr1234@gmail.com>
Date: Wed Nov 15 10:48:13 2017

Migrate ConnectionTypeObserver to NetworkChangeObserver in signaling_connector.h

Bug:  780467 
Change-Id: Idc8e5a7c95f57f286d721a4a187ee18292815df2
Reviewed-on: https://chromium-review.googlesource.com/765307
Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516663}
[modify] https://crrev.com/bb123ecd4b5fc4c1ad81ff075fa7d4aff8e90908/remoting/host/signaling_connector.cc
[modify] https://crrev.com/bb123ecd4b5fc4c1ad81ff075fa7d4aff8e90908/remoting/host/signaling_connector.h

Status: Fixed (was: Available)

Sign in to add a comment