Issue metadata
Sign in to add a comment
|
Migrate extensions/browser/extension_throttle_manager.cc to use net::NetworkChangeNotifier::NetworkChangeObserver |
||||||||||||||||||||||
Issue descriptionnet::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate extensions/browser/extension_throttle_manager.cc to use NetworkChangeObserver instead. See Issue 754695 for the motivation.
,
Nov 5 2017
I am working on this.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e commit 23b3d3cf766dc2073fac457ae3a2baa3a3517b6e Author: shahriar rostami <shahriar.rostami@gmail.com> Date: Mon Nov 06 08:23:40 2017 Replaced obsolete observers with NetworkChangeObserver This CL migrates ExtensionThrottleManager to use NetworkChangeObserver instead of depecated IPAddressObserver and ConnectionTypeObserver. Bug: 780466 Change-Id: I9b829b9d47768b341e960fa2f3b8985ebec6e51c Reviewed-on: https://chromium-review.googlesource.com/754590 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#514098} [modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_manager.cc [modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_manager.h [modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_unittest.cc
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Feb 27 2018
Fixed by shahriar rostami. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Nov 1 2017