New issue
Advanced search Search tips

Issue 780466 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 754695



Sign in to add a comment

Migrate extensions/browser/extension_throttle_manager.cc to use net::NetworkChangeNotifier::NetworkChangeObserver

Project Member Reported by xunji...@chromium.org, Nov 1 2017

Issue description

net::NetworkChangeNotifier's IPAddressObserver and ConnectionTypeObserver are deprecated and will be hidden soon. Please migrate extensions/browser/extension_throttle_manager.cc to use NetworkChangeObserver instead. 

See  Issue 754695  for the motivation.
 
Description: Show this description
I am working on this.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e

commit 23b3d3cf766dc2073fac457ae3a2baa3a3517b6e
Author: shahriar rostami <shahriar.rostami@gmail.com>
Date: Mon Nov 06 08:23:40 2017

Replaced obsolete observers with NetworkChangeObserver

This CL migrates ExtensionThrottleManager to use NetworkChangeObserver instead
of depecated IPAddressObserver and ConnectionTypeObserver.

Bug:  780466 
Change-Id: I9b829b9d47768b341e960fa2f3b8985ebec6e51c
Reviewed-on: https://chromium-review.googlesource.com/754590
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514098}
[modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_manager.cc
[modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_manager.h
[modify] https://crrev.com/23b3d3cf766dc2073fac457ae3a2baa3a3517b6e/extensions/browser/extension_throttle_unittest.cc

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Status: Fixed (was: Available)
Fixed by shahriar rostami.

Sign in to add a comment