New issue
Advanced search Search tips

Issue 780455 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Null-dereference READ in safe_browsing::dmg::HFSBTreeIterator::Next

Project Member Reported by ClusterFuzz, Nov 1 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6534852861231104

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  safe_browsing::dmg::HFSBTreeIterator::Next
  safe_browsing::dmg::HFSIterator::Next
  start
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6534852861231104

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Components: Services>Safebrowsing
Labels: -Pri-1 Pri-2
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Labels: SafeBrowsing-Triaged

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0951256184bfbf3bb7c4b23ee01c24d84841abb7

commit 0951256184bfbf3bb7c4b23ee01c24d84841abb7
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 14 19:26:59 2017

Fix null-deref under safe_browsing::dmg::HFSBTreeIterator::Next().

Bug:  780455 
Change-Id: Ia62983aa7be479e973ff0154ed4ebd276e634dd3
Reviewed-on: https://chromium-review.googlesource.com/769049
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516384}
[modify] https://crrev.com/0951256184bfbf3bb7c4b23ee01c24d84841abb7/chrome/utility/safe_browsing/mac/hfs.cc

Project Member

Comment 5 by ClusterFuzz, Nov 15 2017

ClusterFuzz has detected this issue as fixed in range 516325:516519.

Detailed report: https://clusterfuzz.com/testcase?key=6534852861231104

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  safe_browsing::dmg::HFSBTreeIterator::Next
  safe_browsing::dmg::HFSIterator::Next
  start
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=516325:516519

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6534852861231104

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6534852861231104 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment