Google doodle is not displayed in the second tab page |
||||||
Issue descriptionApp Version: 63.0.3239.27 Beta iOS Version: 11.1, 11.2 Beta, 10.3.3 and 9.3.5 Device: iPhone and iPad Steps to reproduce: 1. Fresh install and launch chrome 2. Navigate to New tab page 3. Wait for few seconds (to let the popular sites load) and open new tab page Observed results: Notice that new tab page (tab 2) is not displaying google doodle Note: Can’t reproduce this issue if the app is force quit and relaunch Expected results: Google doodle should be displayed in all tab pages Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): yes on M62 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M63 Link to video/image: https://drive.google.com/a/google.com/file/d/11CCtV9ZANylmBX3I3BCBEZHSoMvBu4rh/view?usp=sharing
,
Nov 6 2017
,
Nov 7 2017
This is because the first fetch is done at google.com. The second fetch is done at google.fr but the cached metadata url is still google.com. So it is not valid as in: https://cs.chromium.org/chromium/src/components/search_provider_logos/logo_tracker.cc?sq=package:chromium&l=56. The following NTP are fetching on google.fr with a google.fr cached metadata url. Assigning to treib@ as it is related to search_provider_logos.
,
Nov 7 2017
Right, the cached logo is invalidated by the change from .com to your country TLD, which is unfortunate. But the LogoService will just download a new doodle, which the UI fade in once it's available. Is that not implemented on iOS?
,
Nov 7 2017
Hum. Indeed, our logo controller was called but as it was detecting that the logo was already downloaded (on the first NTP), it wasn't reloading it on the second NTP.
,
Nov 7 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/48e2d67f2dca59292e3f7803c8775c925d0e45f2 commit 48e2d67f2dca59292e3f7803c8775c925d0e45f2 Author: Gauthier Ambard <gambard@google.com> Date: Tue Nov 07 15:07:15 2017
,
Nov 7 2017
,
Nov 14 2017
Tested today in latest Canary build, "Google doodle is now displayed in the second tab page" Build: 64.0.3267.0 Canary iOS: 11.1.1,11.2, 10.3.3 Device: iPhone 6, iPhone 8, iPad mini 2, iPad |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sczs@chromium.org
, Nov 1 2017Status: Assigned (was: Untriaged)