New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780416 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Default focus is not seen on Save Button on first instance.

Reported by aiman.an...@etouch.net, Nov 1 2017

Issue description

Chrome Version: 63.0.3239.30 049ea61befc4e3f4b0d2bb500d60f13e790bdee4-refs/branch-heads/3239@{#328}(32/64-bit)

OS: Mac(10.12.6, 10.13.1).

Test URL: https://www.google.com/gmail/about/#

Steps to reproduce:
1.Launch Chrome, go to the above URL, login with valid credentials.
2.On password bubble press tab key until focus reaches Save and observe.

Actual Result: Default focus is not seen on Save Button on first instance.
Expected Result: Default focus should be seen on Save Button on first instance.

This is regression issue broken in ‘M-63’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 63.0.3236.0(Revision:507295)
Bad Build: 63.0.3238.0(Revision:508208)

You are probably looking for a change made after 507637 (known good), but no later than 507638 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/75c1d5ecd30560b94e713881f69ef18d831b3adf..edb9b8c351be1048294578fe1a2f97bad7fbcc1a

Suspect: https://chromium.googlesource.com/chromium/src/+/75c1d5ecd30560b94e713881f69ef18d831b3adf

@phajdan.jr: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
 
Actual Result.mov
3.9 MB Download
Expected Result.mov
3.0 MB Download
Note: Above issue is not seen on Linux and Win OS
Labels: hasbisect-per-revision
Owner: ----
Status: Untriaged (was: Assigned)
I'm not sure why I was assigned this. The mentioned CL does not change behavior.

Comment 4 by kochi@chromium.org, Dec 27 2017

Components: -Blink>HTML>Focus UI>Browser>Passwords
The password save popup is not rendering web contents, it's a part of Chrome
UI.
Owner: vasi...@chromium.org
Based on bisect range suspecting

Implement password selection and viewing on Mac.

The CL changes the layout of the password bubble on Mac according to the mocks.
The password selection combobox and eye icon are now fully functional.

Bug:  769666 ,753806, 768781 
Change-Id: Iac6f6186f07bad3da2e5f66407ddc782b61f1842
Reviewed-on: https://chromium-review.googlesource.com/708261
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507639}


Comment 6 by vabr@chromium.org, Jan 9 2018

Status: Assigned (was: Untriaged)
Triaging: a bug with an owner is assigned.
Status: Fixed (was: Assigned)
That's fixed on Canary with the Mac Views launch.

Sign in to add a comment