WebRTC and Chromium compiler warnings differ, causing errors when rolling WebRTC |
|||
Issue descriptionThe WebRTC CQ accepts size_t -> uint32_t truncations, but the Chromium CQ does not. Appears to be win_clang specific (which, IIRC, means it's running MSVC...). Example roll: https://chromium-review.googlesource.com/c/chromium/src/+/745828. FAILED: obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\88c3b62e1eb0893b8cd57e3f4859c3af27907f64\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_stereo_cc.pdb" ../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134): error C2220: warning treated as error - no 'object' file generated ../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data
,
Nov 1 2017
Oleh, please take a look when you have time.
,
Dec 8 2017
,
Dec 20 2017
This seems to happen because we build with MSVC only for x86 (not for x64) in WebRTC's trybots. If so, the fix will be done in bugs.webrtc.org/8664 |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 1 2017