New issue
Advanced search Search tips

Issue 780411 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

WebRTC and Chromium compiler warnings differ, causing errors when rolling WebRTC

Project Member Reported by maxmorin@chromium.org, Nov 1 2017

Issue description

The WebRTC CQ accepts size_t -> uint32_t truncations, but the Chromium CQ does not. Appears to be win_clang specific (which, IIRC, means it's running MSVC...).

Example roll: https://chromium-review.googlesource.com/c/chromium/src/+/745828.

FAILED: obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj 
ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\88c3b62e1eb0893b8cd57e3f4859c3af27907f64\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes  @obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_stereo_cc.pdb"
../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134): error C2220: warning treated as error - no 'object' file generated
../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/96acb43b2affdd80eef8d0e63cafd9fdef8ff086

commit 96acb43b2affdd80eef8d0e63cafd9fdef8ff086
Author: Max Morin <maxmorin@webrtc.org>
Date: Wed Nov 01 09:53:16 2017

Fix Chromium compile of StereoEncoderAdapter.

WebRTC rolls into Chromium are failing, we should fix it ASAP.

Log:
FAILED:
obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj
ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe
"e:\b\c\win_toolchain\vs_files\88c3b62e1eb0893b8cd57e3f4859c3af27907f64\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe"
/nologo /showIncludes
@obj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj.rsp
/c
../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc
/Foobj/third_party/webrtc/modules/video_coding/webrtc_stereo/stereo_encoder_adapter.obj
/Fd"obj/third_party/webrtc/modules/video_coding/webrtc_stereo_cc.pdb"
../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134):
error C2220: warning treated as error - no 'object' file generated
../../third_party/webrtc/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc(134):
warning C4267: 'argument': conversion from 'size_t' to 'uint32_t',
possible loss of data

Bug:  chromium:780411 
Change-Id: Ia80f4551d0efeebc6d084e951f5c25e8b9401250
Reviewed-on: https://webrtc-review.googlesource.com/17781
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Max Morin <maxmorin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20522}
[modify] https://crrev.com/96acb43b2affdd80eef8d0e63cafd9fdef8ff086/modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc

Owner: oprypin@chromium.org
Status: Assigned (was: Untriaged)
Oleh, please take a look when you have time.
Mergedinto: webrtc:8664
Status: Duplicate (was: Assigned)
This seems to happen because we build with MSVC only for x86 (not for x64) in WebRTC's trybots. If so, the fix will be done in bugs.webrtc.org/8664

Sign in to add a comment