S13nServiceWorker: Implement FetchEvent#clientId We don't populate it yet for subresource requests.
Apologies, applied the wrong component in bulk.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71135db54abd58a57d670150239e28375abb421e commit 71135db54abd58a57d670150239e28375abb421e Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Feb 01 14:45:55 2018 Gardening: NetworkService: add expectation for fetch-event.https.html. The non-S13nServiceWorker path started passing after bug 807818 was fixed, so the S13nServiceWorker path started failing since clientId isn't implemented there. TBR=bashi, shimazu Bug: 807818 , 780405 NOTRY: true Change-Id: I3055b18262e3acd3095227db06b2fa9a67f53564 Reviewed-on: https://chromium-review.googlesource.com/897072 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533658} [add] https://crrev.com/71135db54abd58a57d670150239e28375abb421e/third_party/WebKit/LayoutTests/flag-specific/enable-features=NetworkService/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
I'm going to take this over. WIP (needs more work): https://chromium-review.googlesource.com/c/chromium/src/+/897041
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0631bb8ba9c763e116bd6c245e914f27595bcdc1 commit 0631bb8ba9c763e116bd6c245e914f27595bcdc1 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Feb 09 09:49:23 2018 S13nServiceWorker: Plumb FetchEvent.clientId This CL adds |client_id| field to ControllerServiceWorkerInfo to pass the client id from browser to renderer when a navigation is committed. In renderer, the client id is kept in ControllerServiceWorkerConnector so that ServiceWorkerSubresourceLoader can get it when it dispatches a FetchEvent. Also this CL adds a new mojo struct called DispatchFetchEventParams to put parameters related to FetchEvent together. Bug: 780405 Change-Id: I431bf98eb1efca668162de28a84856c7197675da Reviewed-on: https://chromium-review.googlesource.com/897041 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#535677} [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/browser/service_worker/service_worker_controllee_request_handler.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/browser/service_worker/service_worker_fetch_dispatcher.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/common/BUILD.gn [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/common/service_worker/controller_service_worker.mojom [add] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/common/service_worker/dispatch_fetch_event_params.mojom [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/controller_service_worker_connector.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/controller_service_worker_connector.h [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/controller_service_worker_impl.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/controller_service_worker_impl.h [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_provider_context_unittest.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_subresource_loader.cc [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_subresource_loader.h [modify] https://crrev.com/0631bb8ba9c763e116bd6c245e914f27595bcdc1/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc [delete] https://crrev.com/deaf6f30d7bdef8824aece9d23b001ee572df3e6/third_party/WebKit/LayoutTests/flag-specific/enable-features=NetworkService/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
Comment 1 by laforge@google.com
, Nov 7 2017