New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780403 link

Starred by 2 users
Status: Fixed
Owner:
se...@chromium.org
Closed: Nov 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
se...@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird overlapping is observed in username text-box.

Reported by dchau...@etouch.net, Nov 1 2017 
Chrome Version:64.0.3255.0 (64-bit) fc2679dfa73c1dc102d86832ef049359f433c314-refs/heads/master@{#513029} 32/64-bit.
OS: Windows (7,8,10),Linux (14.04 LTS), Mac(10.12.6, 10.13.1).

What steps will reproduce the problem?
1. Launch chrome and go to www.fb.com
2. Enter any valid username in 'Email or Phone' text-box and press 'Enter' key.
3. Double click on username text-box to auto populate the suggestion list.
4. Now select it using mouse pointer and observe.

Weird overlapping of username is observed in text-box.
No such overlapping of username should seen in text-box.

This is a regression issue, broken in M-64 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Nov 1 2017

Labels: hasbisect-per-revision
Owner: se...@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range and bisect info.

Good build: 64.0.3253.0
Bad build: 64.0.3254.0

You are probably looking for a change made after 512552 (known good), but no later than 512553 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/dcda35961fbbe8484a8d073e5a802b1fe9bb25ae..018bf76b5eb54811482aff02d07c14f4e1ce3c36

Suspect: https://chromium.googlesource.com/chromium/src/+/018bf76b5eb54811482aff02d07c14f4e1ce3c36

@sebsg: Kindly help to reassign, if your changes are not related to this issue.

Note: This issue is reproducible on all the sites like Twitter, Alibaba etc.

Kindly review the attached screen-cast for reference.
Overlapping_Screenshot.png
5.0 KB View Download
Actual behavior.mp4
837 KB View Download
Expected behavior.mp4
516 KB View Download

Comment 2 by rbasuvula@chromium.org, Nov 1 2017

Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 3 by se...@chromium.org, Nov 1 2017

Status: Started (was: Assigned)
It's an issue with fields that have a placeholder in them I think. I'm on it. 

thanks for finding this :)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee053cd8e297c3dc93b20200e3094a844716469

commit 8ee053cd8e297c3dc93b20200e3094a844716469
Author: sebsg <sebsg@chromium.org>
Date: Mon Nov 13 21:05:17 2017

[Autofill] Update placeholder visibility on suggested value change.

Bug:  780403 
Change-Id: I0af3cbbddced641844b29e059193fa666ce36729
Reviewed-on: https://chromium-review.googlesource.com/750061
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516044}
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt
[add] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autofill-value-after-suggested-value-with-placeholder-expected.html
[add] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autofill-value-after-suggested-value-with-placeholder.html
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/LayoutTests/platform/win7/fast/forms/suggested-value-expected.txt
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/8ee053cd8e297c3dc93b20200e3094a844716469/third_party/WebKit/Source/core/testing/Internals.idl

Comment 5 by jmukthavaram@chromium.org, Nov 21 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3274.0
Tested this issue on Windows 7,Mac 10.12.6 & ubuntu 14.04 using chrome latest canary-64.0.3274.0 as per C#0.
Observed no such overlapping of username seen in text-box .As it is working as intended, adding TE Verified labels.

Please find the attached screencast for reference.
Thanks..!
780403.mp4
1.0 MB View Download

Comment 6 by se...@chromium.org, Nov 21 2017

Status: Fixed (was: Started)

Comment 7 by se...@chromium.org, Nov 21 2017

Cc: se...@chromium.org
 Issue 783091  has been merged into this issue.
►

Sign in to add a comment