New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780389 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Weird boxes are seen instead of icons for www.evergreenexports.net

Reported by rp...@etouch.net, Nov 1 2017

Issue description

Version: 63.0.3239.30 (32/64-bit)049ea61befc4e3f4b0d2bb500d60f13e790bdee4-refs/branch-heads/3239@{#328}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1)
URL : http://www.evergreenexports.net/

What steps will reproduce the problem?
1. Launch chrome, navigate to above url and observe icons in top RHS after loading page

Actual: Weird boxes are seen instead of icons
Expected: Icons should be seen properly

This is regression issue, broken in ‘M 63’ and will soon update other info :
Good build:63.0.3227.0
Bad build: 63.0.3228.0
 
Actual_screenshot.png
1.9 MB View Download
Expected_screenshot.png
1.9 MB View Download

Comment 1 by rp...@etouch.net, Nov 1 2017

Labels: hasbisect-per-revision
Owner: japhet@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 63.0.3227.0 (Revision: 505232).
Bad build: 63.0.3228.0 (Revision: 505449).

You are probably looking for a change made after 505410 (known good), but no lat
er than 505411 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/4780ccc827fe95f1853e398f7ae24560c3fee34b..126dc76bd00c11209ccf65ea151d5263fde0c7dc

From the CL above, assigning the issue to the concern owner 

@dpapad- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/126dc76bd00c11209ccf65ea151d5263fde0c7dc

Thanks!
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 3 by rp...@etouch.net, Nov 1 2017

Correction :

@japhet- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/126dc76bd00c11209ccf65ea151d5263fde0c7dc

Thanks!
Labels: Update-Weekly
Labels: -ReleaseBlock-Stable
Status: Started (was: Assigned)
This is a combination of a bug in chrome and a bug on the website.

The website has a list of fonts it wants to use. We try to load the first font, and if it fails, we try to load the second one, etc. I broke that fallback to the second choice in the specific case of the request failing because of a 4xx/5xx response.

Since the website could fix this by removing the non-existent font from their list, I don't think this is a release blocker. I'll still make a best effort to get it fixed soon and merged to M63.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8bfda2014e0a78237cc57de958898a6594faf29

commit d8bfda2014e0a78237cc57de958898a6594faf29
Author: Nate Chapin <japhet@chromium.org>
Date: Mon Nov 06 20:14:46 2017

Revert "If a font resource load is cancelled, don't fallback to a different font."

Some cases are flagged as cancellations that aren't exactly, and that we want
to fall back after.

This reverts commit 126dc76bd00c11209ccf65ea151d5263fde0c7dc.

TBR=toyoshim

Bug:  780389 ,  781270 
Change-Id: Ib8d6f96e63c1cd9b87e87c8651b7fdbafa69e460
Reviewed-on: https://chromium-review.googlesource.com/755316
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514226}
[modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/CSSFontFace.h
[modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Comment 7 by rp...@etouch.net, Nov 7 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3261.0
Note :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with latest canary chrome version : 64.0.3261.0 and the issue is not reproduced.Kindly refer attached screen cast for reference.
Actual_video.mp4
704 KB View Download
Labels: Merge-Request-63
NextAction: 2017-11-10
japhet@ to check Canary stability on Friday. Thank you.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 7 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The NextAction date has arrived: 2017-11-10
I haven't been crash reports from recent canaries that would indicate a regression from the revert. I'm as confident as I can be that this is safe to merge.
Labels: -Merge-Review-63 Merge-Approved-63
Approving merge to M63 branch 3239 based on comment #7 and #12. Please merge ASAP. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 10 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9

commit 994d3c17a0623dcfdfb563e1db7640f10bb2ecc9
Author: Nate Chapin <japhet@chromium.org>
Date: Fri Nov 10 19:58:43 2017

Revert "If a font resource load is cancelled, don't fallback to a different font."

Some cases are flagged as cancellations that aren't exactly, and that we want
to fall back after.

This reverts commit 126dc76bd00c11209ccf65ea151d5263fde0c7dc.

TBR=japhet@chromium.org, toyoshim

(cherry picked from commit d8bfda2014e0a78237cc57de958898a6594faf29)

Bug:  780389 ,  781270 
Change-Id: Ib8d6f96e63c1cd9b87e87c8651b7fdbafa69e460
Reviewed-on: https://chromium-review.googlesource.com/755316
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514226}
Reviewed-on: https://chromium-review.googlesource.com/764371
Cr-Commit-Position: refs/branch-heads/3239@{#442}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/CSSFontFace.h
[modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Status: Fixed (was: Started)

Comment 16 by rp...@etouch.net, Nov 15 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3239.52
Note :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with Beta chrome version : 63.0.3239.52 and the issue is not reproduced.Kindly refer attached screen cast for reference.
Actual_video.mov
1.2 MB Download

Sign in to add a comment