Issue metadata
Sign in to add a comment
|
Regression : Weird boxes are seen instead of icons for www.evergreenexports.net
Reported by
rp...@etouch.net,
Nov 1 2017
|
||||||||||||||||||||||
Issue descriptionVersion: 63.0.3239.30 (32/64-bit)049ea61befc4e3f4b0d2bb500d60f13e790bdee4-refs/branch-heads/3239@{#328} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) URL : http://www.evergreenexports.net/ What steps will reproduce the problem? 1. Launch chrome, navigate to above url and observe icons in top RHS after loading page Actual: Weird boxes are seen instead of icons Expected: Icons should be seen properly This is regression issue, broken in ‘M 63’ and will soon update other info : Good build:63.0.3227.0 Bad build: 63.0.3228.0
,
Nov 1 2017
Tagging with blocker label, please undo if not the case.
,
Nov 1 2017
Correction : @japhet- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Suspect : https://chromium.googlesource.com/chromium/src/+/126dc76bd00c11209ccf65ea151d5263fde0c7dc Thanks!
,
Nov 2 2017
,
Nov 2 2017
This is a combination of a bug in chrome and a bug on the website. The website has a list of fonts it wants to use. We try to load the first font, and if it fails, we try to load the second one, etc. I broke that fallback to the second choice in the specific case of the request failing because of a 4xx/5xx response. Since the website could fix this by removing the non-existent font from their list, I don't think this is a release blocker. I'll still make a best effort to get it fixed soon and merged to M63.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8bfda2014e0a78237cc57de958898a6594faf29 commit d8bfda2014e0a78237cc57de958898a6594faf29 Author: Nate Chapin <japhet@chromium.org> Date: Mon Nov 06 20:14:46 2017 Revert "If a font resource load is cancelled, don't fallback to a different font." Some cases are flagged as cancellations that aren't exactly, and that we want to fall back after. This reverts commit 126dc76bd00c11209ccf65ea151d5263fde0c7dc. TBR=toyoshim Bug: 780389 , 781270 Change-Id: Ib8d6f96e63c1cd9b87e87c8651b7fdbafa69e460 Reviewed-on: https://chromium-review.googlesource.com/755316 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#514226} [modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/CSSFontFace.cpp [modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/CSSFontFace.h [modify] https://crrev.com/d8bfda2014e0a78237cc57de958898a6594faf29/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
,
Nov 7 2017
Note : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with latest canary chrome version : 64.0.3261.0 and the issue is not reproduced.Kindly refer attached screen cast for reference.
,
Nov 7 2017
,
Nov 7 2017
japhet@ to check Canary stability on Friday. Thank you.
,
Nov 7 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Nov 10 2017
I haven't been crash reports from recent canaries that would indicate a regression from the revert. I'm as confident as I can be that this is safe to merge.
,
Nov 10 2017
Approving merge to M63 branch 3239 based on comment #7 and #12. Please merge ASAP. Thank you.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9 commit 994d3c17a0623dcfdfb563e1db7640f10bb2ecc9 Author: Nate Chapin <japhet@chromium.org> Date: Fri Nov 10 19:58:43 2017 Revert "If a font resource load is cancelled, don't fallback to a different font." Some cases are flagged as cancellations that aren't exactly, and that we want to fall back after. This reverts commit 126dc76bd00c11209ccf65ea151d5263fde0c7dc. TBR=japhet@chromium.org, toyoshim (cherry picked from commit d8bfda2014e0a78237cc57de958898a6594faf29) Bug: 780389 , 781270 Change-Id: Ib8d6f96e63c1cd9b87e87c8651b7fdbafa69e460 Reviewed-on: https://chromium-review.googlesource.com/755316 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#514226} Reviewed-on: https://chromium-review.googlesource.com/764371 Cr-Commit-Position: refs/branch-heads/3239@{#442} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/CSSFontFace.cpp [modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/CSSFontFace.h [modify] https://crrev.com/994d3c17a0623dcfdfb563e1db7640f10bb2ecc9/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
,
Nov 10 2017
,
Nov 15 2017
Note : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with Beta chrome version : 63.0.3239.52 and the issue is not reproduced.Kindly refer attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rp...@etouch.net
, Nov 1 2017Owner: japhet@chromium.org
Status: Assigned (was: Unconfirmed)