Cannot read encrypted file in zip |
|||||||
Issue descriptionChrome Version: ToT; Also seen in Canary on Nov. 1. Steps To Reproduce: (1) Create encrypted zip file. For example, [zip a.zip -e a.jpg] and set password. Copy it to device's Downloads folder. (2) Double-click the file in the Files app. See the zip file is mounted as a volume. (3) Try to open the image file in the zip file. Expected Result: User is asked for password by the Files app. before showing thumbnails. Gallery app opens. User is asked for password. The image is loaded and displayed. Actual Result: Gallery app opens. The image load doesn't finish indefinitely. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) 100% Impact & workaround: User may fail to read an encrypted zip files. No workaround known right now.
,
Nov 1 2017
,
Nov 1 2017
It works fine on M57. yamaguchi@, could you check if it reproduces on stable channel? If it is a recent regression, we should fix it and merge the fix asap.
,
Nov 1 2017
This was OK at commit 4316c85, when the change 666936: [Zip Archiver: Remember a password if checkbox is checked] was landed.
,
Nov 1 2017
Not reproduced on 61.0.3163.123
,
Nov 1 2017
This is happening since commit bdf17920ad6a1d02c97159fb0e986eaf2c7fc30f. https://chromium-review.googlesource.com/c/chromium/src/+/732811
,
Nov 1 2017
,
Nov 1 2017
Thank you for identifying the commit! ZIP Unpacker extension uses Polymer 0.5.2(!) to implement the password dialog etc.. It might explain why it's broken since https://chromium-review.googlesource.com/c/chromium/src/+/732811 I'll see if updating Polymer version fixes the issue.
,
Nov 1 2017
I didn't realize that Files.app used such old Polymer version. Didn't you take any action on deprecation message...? Anyway, it is removed at M64 so could you fix this before M64 branch?
,
Nov 1 2017
Files.app uses a newer Polymer (1.9.1), but ZIP Unpacker is a separated extension which has unchanged for more than two years, and it seems it's been out of our attention... ZIP Unpacker is not in Chrome repository and it can be updated automatically via Chrome Web Store. We'll update the Polymer version of ZIP Unpacker before M64 goes to beta.
,
Nov 1 2017
Thanks, good to hear that. Maybe you can close this if this is not Chrome issue itself, but feel free to close after once the new extension is available at CWS.
,
Nov 1 2017
Once the new version of ZIP Unpacker is published to 100% of M64 users, I'll update this bug and close it. Thanks!
,
Nov 8 2017
+vapier@, since the same issue might happen in Wicked Good Unarchiver.
,
Nov 8 2017
I'm upgrading the Polymer and PolymerElements version in ZIP unpacker to use the same versions with Chrome Web UI. https://codesearch.chromium.org/chromium/src/third_party/polymer/v1_0/bower.json
,
Nov 8 2017
thanks. usually i just rebase on top of the latest unpacker repo, so once the update lands there, i'll pick it up :).
,
Nov 9 2017
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/unpacker/+/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc commit fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc Author: Naoki Fukino <fukino@chromium.org> Date: Fri Dec 01 06:10:12 2017 Upgrade Polymer to 1.9.1. An old Polymer version (0.5) is used to implement the password dialog. This old version is not supported anymore and stop working on M64. This patch updates the version to 1.9.1. The Chrome Web UI uses the same version of Polymer. BUG= chromium:780381 TEST=Comfirmed that an encrypted zip file was unpacked with this patch. Change-Id: Ibee537daedac7e9141b3be4ae0aed951555fbb78 [modify] https://crrev.com/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc/unpacker/js/passphrase-dialog.js [modify] https://crrev.com/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc/unpacker/Makefile [modify] https://crrev.com/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc/unpacker/html/passphrase-dialog.html [modify] https://crrev.com/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc/README.md [modify] https://crrev.com/fd5ab5cd3ceef9845968c019d397fb77fa4ffcfc/third-party/polymer/bower.json
,
Dec 7 2017
The fix was already delivered to M64+ users. Marking as Fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yamaguchi@chromium.org
, Nov 1 2017