Issue 780378 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	hajimehoshi@chromium.org
Closed:	Nov 2017
Cc:	altimin@chromium.org haraken@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Rename SuspendableObject -> PausableObject

Project Member Reported by hajimehoshi@chromium.org, Nov 1 2017

Issue description

Now schedulers use the term 'pausable', but SuspendableObject still remains, which is not consisntent.

Comment 1 by hajimehoshi@chromium.org, Nov 1 2017

Labels: -Type-Bug Type-Task

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e

commit 22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 01 08:52:22 2017

Rename SuspendableObject to PausableObject and keep SuspendablObject as an alias

This is the first step to replace all SuspendableObject with PausableObject.

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: I76781b850f8a1c71f4a01178d3fd7432534adc06
Reviewed-on: https://chromium-review.googlesource.com/749022
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513099}
[modify] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/ExecutionContext.h
[rename] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/PausableObject.cpp
[add] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/PausableObject.h
[rename] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/PausableObjectTest.cpp
[modify] https://crrev.com/22bdcdd3bb31ab13b2fa2f69ac81d3543e07fb2e/third_party/WebKit/Source/core/dom/SuspendableObject.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b

commit cf79f965f2bfd5f351b6ab1e3396a361632c2d2b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 01 11:46:10 2017

Add PausableObject::Pause(IfNeeded)/Unpause to replace Suspend(IfNeeded)/Resume

This CL also replaces caller side of Suspend(IfNeeded)/Resume to use
Pause(IfNeeded)/Unpause.

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: Ie228c1e2e498ff5c65a877e4cf24dc92c9714039
Reviewed-on: https://chromium-review.googlesource.com/748722
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513106}
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/css/FontFaceSetDocument.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/css/FontFaceSetWorker.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/PausableObject.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/PausableObject.h
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/PausableObjectTest.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/dom/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/html/media/HTMLAudioElement.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/html/media/HTMLVideoElement.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/cf79f965f2bfd5f351b6ab1e3396a361632c2d2b/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e83758dedba16fccc4366f3c55c1f0fb5d47f017

commit e83758dedba16fccc4366f3c55c1f0fb5d47f017
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 01 13:40:46 2017

Rename SuspendableObjectsInfo -> PausableObjectsInfo

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: I7b191160836f22a620d5a33d88c4d9a8a955705d
Reviewed-on: https://chromium-review.googlesource.com/749122
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513117}
[modify] https://crrev.com/e83758dedba16fccc4366f3c55c1f0fb5d47f017/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
[modify] https://crrev.com/e83758dedba16fccc4366f3c55c1f0fb5d47f017/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h
[modify] https://crrev.com/e83758dedba16fccc4366f3c55c1f0fb5d47f017/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164

commit 8912900b9a37a4c2c4a76f93aa167bb0f8fb1164
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Nov 02 08:57:32 2017

Rename AsyncMethodRunner::Suspend/Resume -> Pause/Unpause

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: I622ca8aad24913ad5bf78f4f440b099620e89304
Reviewed-on: https://chromium-review.googlesource.com/750423
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513429}
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/8912900b9a37a4c2c4a76f93aa167bb0f8fb1164/third_party/WebKit/Source/platform/AsyncMethodRunner.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406d5b98ea88dcb8d592e486b9886023769c0a66

commit 406d5b98ea88dcb8d592e486b9886023769c0a66
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Nov 02 10:09:41 2017

Rename DOMWebSocket::EventQueue::Suspend/Resume -> Pause/Unpause

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: Id0afd1f3b0bfd71982909aba6cd54d427c7a2588
Reviewed-on: https://chromium-review.googlesource.com/750742
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513446}
[modify] https://crrev.com/406d5b98ea88dcb8d592e486b9886023769c0a66/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/406d5b98ea88dcb8d592e486b9886023769c0a66/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56

commit 4d0cd4e7941e250fcbc88ee39ffb9f169a42db56
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Nov 02 12:09:01 2017

Rename functions in ExecutionContext to use the terms Pause/Unpause

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: If130145f64b830b0661a073f1e2eabd1f8f99e1d
Reviewed-on: https://chromium-review.googlesource.com/750745
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513463}
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/boolean_or_element_sequence.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_long_callback_function.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/core/v8_void_callback_function_typedef.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/bindings/tests/results/modules/v8_void_callback_function_modules.cc
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/PausableObject.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/dom/PausableObjectTest.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverTest.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/4d0cd4e7941e250fcbc88ee39ffb9f169a42db56/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ffde934435e21e9315b87c559d76b7e007f28e

commit b4ffde934435e21e9315b87c559d76b7e007f28e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Nov 03 09:04:17 2017

Rename functions in HTMLParserScheduler to use the terms Pause/Unpause

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: I2a54bbeb9eebd97478a25edfef241244ccf126a6
Reviewed-on: https://chromium-review.googlesource.com/751001
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513728}
[modify] https://crrev.com/b4ffde934435e21e9315b87c559d76b7e007f28e/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/b4ffde934435e21e9315b87c559d76b7e007f28e/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp
[modify] https://crrev.com/b4ffde934435e21e9315b87c559d76b7e007f28e/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2727812421e1d947313ac60a82f6607c655572f

commit f2727812421e1d947313ac60a82f6607c655572f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Nov 07 14:46:45 2017

Replace all SuspendableObject usages with PausableObject

This CL also replaces Suspend/Resume functions with Pause/Unpause
functions.

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2e64d3f8f0c608122af73140ffafd2a3178e7f9e
Reviewed-on: https://chromium-review.googlesource.com/754642
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514467}
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics-expected.txt
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/css/FontFaceSetDocument.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/css/FontFaceSetWorker.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/PausableObject.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/PausableObject.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/PausableObjectTest.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ScriptedAnimationController.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h
[delete] https://crrev.com/d138e38ab67e6badaacbd041dcdd67eeeaadd735/third_party/WebKit/Source/core/dom/SuspendableObject.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/dom/events/EventTarget.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/frame/SuspendableTimer.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/html/media/HTMLMediaElement.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/html/media/HTMLVideoElement.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/leak_detector/WebLeakDetector.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/battery/BatteryManager.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/eventsource/EventSource.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/sensor/Sensor.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h
[modify] https://crrev.com/f2727812421e1d947313ac60a82f6607c655572f/third_party/WebKit/Source/platform/InstanceCounters.h

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6d2d5565d71361c330dbfae1923a3f48a2151f

commit 2d6d2d5565d71361c330dbfae1923a3f48a2151f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 08 08:42:03 2017

Rename SuspendableObject to PausableObject in the leak detector

This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663

Bug:  780378 
Change-Id: I575491bdac0a5d166598893a18dc1ba3f0f51c05
Reviewed-on: https://chromium-review.googlesource.com/758183
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514782}
[modify] https://crrev.com/2d6d2d5565d71361c330dbfae1923a3f48a2151f/content/public/test/render_view_test.cc
[modify] https://crrev.com/2d6d2d5565d71361c330dbfae1923a3f48a2151f/content/shell/renderer/layout_test/leak_detector.cc
[modify] https://crrev.com/2d6d2d5565d71361c330dbfae1923a3f48a2151f/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/2d6d2d5565d71361c330dbfae1923a3f48a2151f/third_party/WebKit/Source/core/leak_detector/WebLeakDetector.cpp
[modify] https://crrev.com/2d6d2d5565d71361c330dbfae1923a3f48a2151f/third_party/WebKit/public/web/WebLeakDetector.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5cb91d90879a3bdb3d33bc179b1fc051079fd08

commit b5cb91d90879a3bdb3d33bc179b1fc051079fd08
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Nov 09 17:05:52 2017

Rename ExecutionContext functions to use Pause/Unpause

Bug:  780378 
Change-Id: I7b61822c1789d21599ae73b14566f2abe169f0d2
Reviewed-on: https://chromium-review.googlesource.com/760045
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515190}
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/testing/NullExecutionContext.cpp
[modify] https://crrev.com/b5cb91d90879a3bdb3d33bc179b1fc051079fd08/third_party/WebKit/Source/core/testing/NullExecutionContext.h

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/500392eb0289b96d17134ade9e3281e4a40d7878

commit 500392eb0289b96d17134ade9e3281e4a40d7878
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Nov 13 11:06:59 2017

Rename SuspendableObject to PausableObject in comments and consts

TBR=hajimehoshi@chromium.org

Bug:  780378 
Change-Id: Ie3ced9c5c0a1914d9fa329d36209634d2ae55383
Reviewed-on: https://chromium-review.googlesource.com/763269
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515922}
[modify] https://crrev.com/500392eb0289b96d17134ade9e3281e4a40d7878/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/500392eb0289b96d17134ade9e3281e4a40d7878/content/shell/renderer/layout_test/leak_detector.cc
[modify] https://crrev.com/500392eb0289b96d17134ade9e3281e4a40d7878/media/blink/webmediaplayer_impl.h

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866b71163824c6c60ac37de03bda222f08221f44

commit 866b71163824c6c60ac37de03bda222f08221f44
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Nov 14 18:21:44 2017

Rename Internals.suspendableObject -> Internals.pausableObject

Bug:  780378 
Change-Id: Iaa3c4760231696205d08b9558aa62f476ab57ce2
Reviewed-on: https://chromium-review.googlesource.com/768774
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516363}
[modify] https://crrev.com/866b71163824c6c60ac37de03bda222f08221f44/third_party/WebKit/LayoutTests/http/tests/activedomobject/media-expected.txt
[modify] https://crrev.com/866b71163824c6c60ac37de03bda222f08221f44/third_party/WebKit/LayoutTests/http/tests/activedomobject/media.html
[modify] https://crrev.com/866b71163824c6c60ac37de03bda222f08221f44/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/866b71163824c6c60ac37de03bda222f08221f44/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/866b71163824c6c60ac37de03bda222f08221f44/third_party/WebKit/Source/core/testing/Internals.idl

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/6a390a266fd4a98ca6c349758d7b415e72393f7c

commit 6a390a266fd4a98ca6c349758d7b415e72393f7c
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 15 05:22:49 2017

Rename SuspendableObject -> PausableObject

This CL syncs BLINK_OBJECT_LIST with the latest InstanceCounters.h

Bug: chromium:780378 
Change-Id: Iec5373e708a050fddace1bd9942a45a56f2f74de
Reviewed-on: https://chromium-review.googlesource.com/768602
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>

[modify] https://crrev.com/6a390a266fd4a98ca6c349758d7b415e72393f7c/tracing/tracing/metrics/blink/leak_detection_metric_test.html

Comment 15 by hajimehoshi@chromium.org, Nov 15 2017

There are some remaining tasks like:

* Rename HTMLDocumentParser::tasks_were_suspended_
* Rename OfflineAudioContext::ShouldSuspend
* Rename SuspendableTimer
* Rename SuspendableScriptExecutor

As they are not urgent, I (or someone) will do them later when available.

Comment 16 by hajimehoshi@chromium.org, Nov 17 2017

> * Rename OfflineAudioContext::ShouldSuspend

I'm not sure but this seems not related to PausableObject.


Another item:

* ScriptRunner::Suspend()

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57

commit ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Nov 17 13:32:30 2017

Use the terms Pause/Unpause instead of Suspend/Resume in Blink

Bug:  780378 
Change-Id: Iac3e165e9721dc9fbe4b1771f8a85e89b98e0056
Reviewed-on: https://chromium-review.googlesource.com/775611
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517392}
[modify] https://crrev.com/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57/third_party/WebKit/Source/core/dom/DocumentParser.cpp
[modify] https://crrev.com/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57/third_party/WebKit/Source/core/dom/DocumentParser.h
[modify] https://crrev.com/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/ed08e77a52d977fdb8f4c2a0b27e3d5a73019a57/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557e8d000ddf8f3d8a5209ab7c166afe927df87d

commit 557e8d000ddf8f3d8a5209ab7c166afe927df87d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 22 08:16:18 2017

Rename SuspendableTimer -> PausableTimer

Bug:  780378 
Change-Id: I6b3bfd0afb9547b94c00f3617994c5ef8be72a89
Reviewed-on: https://chromium-review.googlesource.com/784555
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518565}
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/dom/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[rename] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/PausableTimer.cpp
[rename] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/PausableTimer.h
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/557e8d000ddf8f3d8a5209ab7c166afe927df87d/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.h

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d

commit 678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 22 11:12:15 2017

Rename SuspendableScriptExecutor -> PausableScriptExecutor

Bug:  780378 
Change-Id: I69b5822d50b8cd1cbd281ab6486a40f7e459a091
Reviewed-on: https://chromium-review.googlesource.com/784656
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518602}
[modify] https://crrev.com/678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d/third_party/WebKit/Source/core/frame/BUILD.gn
[rename] https://crrev.com/678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d/third_party/WebKit/Source/core/frame/PausableScriptExecutor.cpp
[rename] https://crrev.com/678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d/third_party/WebKit/Source/core/frame/PausableScriptExecutor.h
[modify] https://crrev.com/678d7225fd0b4d40c027cfe84cbd4f4d97cb2d5d/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp

Comment 20 by hajimehoshi@chromium.org, Nov 22 2017

Status: Fixed (was: Started)

Finished!

►

Issue 780378 link

Issue metadata

Rename SuspendableObject -> PausableObject

Issue description

Comment 1 by hajimehoshi@chromium.org, Nov 1 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Nov 1 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Nov 2 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Nov 2 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 2 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 3 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Nov 7 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Nov 9 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Nov 13 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 14 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 15 2017

Comment 14 Deleted

Comment 15 by hajimehoshi@chromium.org, Nov 15 2017

Comment 15 Deleted

Comment 16 by hajimehoshi@chromium.org, Nov 17 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Nov 17 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Nov 22 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Nov 22 2017

Comment 19 Deleted

Comment 20 by hajimehoshi@chromium.org, Nov 22 2017

Comment 20 Deleted

Sign in to add a comment