New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780358 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 634542



Sign in to add a comment

Null-dereference READ in blink::ApplyColorSpaceConversion

Project Member Reported by ClusterFuzz, Nov 1 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6725794088091648

Fuzzer: inferno_twister
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  blink::ApplyColorSpaceConversion
  blink::ImageBitmap::ImageBitmap
  blink::ImageBitmap::Create
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=512306:512363

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6725794088091648

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: kkaluri@chromium.org
Components: Blink>Image
Labels: M-64 Test-Predator-Wrong
Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “ImageBitmap.cpp” assigning to concern owner.

Suspecting Commit# https://chromium.googlesource.com/chromium/src/+/5696a13dd71bbec8c7e86507e4353b4e9af0f8f7

zakerinasab@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Thank You...
Status: Started (was: Assigned)
A cl is uploaded for review that should fix this. I'll try to land it asap.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c2494ddaca47ad39b33126d67e2ca579b03772

commit d0c2494ddaca47ad39b33126d67e2ca579b03772
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu Nov 02 16:15:31 2017

Protect StaticBitmapImage refereces against nullptr in ImageBitmap

This change adds some checks to ImageBitmap to protect scoped_refptr<StaticBitmapImage> objects
usages against failures in memory allocations, etc.

Bug:  780358 
Change-Id: I05bd4b048d0fcef8ceed933175be8ecad065830f
Reviewed-on: https://chromium-review.googlesource.com/749527
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513505}
[modify] https://crrev.com/d0c2494ddaca47ad39b33126d67e2ca579b03772/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/d0c2494ddaca47ad39b33126d67e2ca579b03772/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp

This should be fixed now. Waiting for automatic verify by the fuzzer.
Project Member

Comment 6 by ClusterFuzz, Nov 3 2017

ClusterFuzz has detected this issue as fixed in range 513496:513524.

Detailed report: https://clusterfuzz.com/testcase?key=6725794088091648

Fuzzer: inferno_twister
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  blink::ApplyColorSpaceConversion
  blink::ImageBitmap::ImageBitmap
  blink::ImageBitmap::Create
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=512306:512363
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=513496:513524

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6725794088091648

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6725794088091648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Blocking: 634542

Sign in to add a comment