New issue
Advanced search Search tips

Issue 780354 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in ConstantUnion::operator-

Project Member Reported by ClusterFuzz, Nov 1 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6340052337819648

Fuzzer: libFuzzer_swiftshader_vertex_routine_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x6250000a7104
Crash State:
  ConstantUnion::operator-
  TIntermediate::addBinaryMath
  TParseContext::addBinaryMath
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=512521:512621

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6340052337819648

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 1 2017

Labels: M-64
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 1 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 1 2017

Labels: Pri-1
Components: Internals>GPU>SwiftShader

Comment 5 by vakh@chromium.org, Nov 2 2017

Owner: capn@chromium.org
Status: Assigned (was: Untriaged)
Based on https://swiftshader.googlesource.com/SwiftShader.git/+log/6e27fea..e2febff

Comment 6 by capn@chromium.org, Nov 3 2017

Labels: -Pri-1 -ReleaseBlock-Stable ReleaseBlock-NA Pri-2

Comment 7 by vakh@chromium.org, Nov 3 2017

capn -- so that I mark future bugs appropriately as "ReleaseBlock-NA", can you please tell me why this is ReleaseBlock-NA?
Is this code not enabled by default? Sorry, I don't have much insight into it.

Comment 8 by capn@chromium.org, Nov 4 2017

Hi Varun, thanks for inquiring. SwiftShader runs inside the GPU process, which sandboxes it against security vulnerabilities. Note that the GPU process typically runs the GPU driver, which is code we don't own and is inherently untrusted. Crashing the GPU process is not entirely uncommon, and after three attempts we don't launch it any more.

That said, we absolutely intend to fix these bugs, but we currently don't have the headcount to do it within a release cycle.
Project Member

Comment 9 by ClusterFuzz, Nov 5 2017

Labels: OS-Linux
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 18 2017

capn: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 3 2017

capn: Uh oh! This issue still open and hasn't been updated in the last 29 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by ClusterFuzz, Dec 6 2017

ClusterFuzz has detected this issue as fixed in range 521385:521603.

Detailed report: https://clusterfuzz.com/testcase?key=6340052337819648

Fuzzer: libFuzzer_swiftshader_vertex_routine_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x6250000a7104
Crash State:
  ConstantUnion::operator-
  TIntermediate::addBinaryMath
  TParseContext::addBinaryMath
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=512521:512621
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=521385:521603

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6340052337819648

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Dec 6 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6340052337819648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 6 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable

Sign in to add a comment