Material Rietveld is broken + I can't switch to "deprecated UI" |
|||
Issue descriptionhttps://codereview.chromium.org/2278513003/ shows "Failed to load issue 2278513003. :(" (see screenshot) when I'm logged in. Similarly, https://codereview.chromium.org/search doesn't work (see screenshot). In both cases, this appears to be due to JS failures during DOM-related operations. The "deprecated UI" works when I view Rietveld without being logged in. However, since Rietveld is read-only, I can't modify my settings to "deprecated UI". If it's not worth fixing the Material Rietveld UI for read-only, could we disable it and always show the other one?
,
Nov 6 2017
Also happens for chromereviews.googleplex.com (which defaults to the Material UI, if I recall correctly).
,
Nov 9 2017
*ping*
,
Nov 9 2017
Yes, I'm working on it. I'm also in London for a conference. (And no, chromereviews doesn't default to the material UI, it's still based on your user preference. Which you can't change right now. Working on it.)
,
Nov 29 2017
,
Nov 29 2017
,
Nov 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/511041c7a8b0cc551d6e3340be9572de8a667f22 commit 511041c7a8b0cc551d6e3340be9572de8a667f22 Author: Aaron Gable <agable@chromium.org> Date: Thu Nov 30 00:33:44 2017
,
Nov 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/e71eb5ebdb5200497414eaea20204bef02409360 commit e71eb5ebdb5200497414eaea20204bef02409360 Author: Aaron Gable <agable@google.com> Date: Thu Nov 30 01:40:26 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5af01dd6df68d74111d983afa1d0802b458c9104 commit 5af01dd6df68d74111d983afa1d0802b458c9104 Author: Aaron Gable <agable@chromium.org> Date: Thu Nov 30 01:59:45 2017 Fix 500s from json serialization of datetimes This was caused by https://crrev.com/c/721777, which replaced a wrapper around issue.get_time_since_landed() with a direct call, but failed to reduce the result down to just its .days segment. Bug: 780334 Change-Id: I90d5c9dd3f31414f3a0d220e964275622477f6a4 Reviewed-on: https://chromium-review.googlesource.com/798118 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/5af01dd6df68d74111d983afa1d0802b458c9104/appengine/chromium_rietveld/codereview/views.py
,
Nov 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7c924e5206bcee9c91c90ad7b4176ad2488ab6a2 commit 7c924e5206bcee9c91c90ad7b4176ad2488ab6a2 Author: Aaron Gable <agable@chromium.org> Date: Thu Nov 30 02:22:13 2017
,
Dec 1 2017
The new version has been released, and the above-referenced changes now all load in both the old and polymer UIs. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lgar...@chromium.org
, Nov 1 2017