Create glRenderbufferStorageMultisampleFn if GL_ARB_framebuffer_object extension exists |
||
Issue descriptionWe create glRenderbufferStorageMultisampleFn if the gl version is >= 3.0: https://cs.chromium.org/chromium/src/ui/gl/gl_bindings_autogen_gl.cc?type=cs&l=1852 We should also create it if GL_ARB_framebuffer_object extension exists as well. This would allow us to use oop raster in unittests that use osmesa. Currently this fails to create a GrContext because validation fails in skia. Assigning to piman@ as per offline discussion.
,
Nov 2 2017
Cool, thanks for looking into this!
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0d29093152f07f215c996b6576b9ed288ddefbe commit c0d29093152f07f215c996b6576b9ed288ddefbe Author: Antoine Labour <piman@chromium.org> Date: Thu Nov 02 02:07:19 2017 Fully support GL_ARB_map_buffer_range/GL_EXT_map_buffer_range bindings Skia expects the bindings for FlushMappedBufferRange to be present if either extension exists. Bug: 780320 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iff7dbe4a40b01017c8b59b7e3e8b3e42610c1f5b Reviewed-on: https://chromium-review.googlesource.com/749992 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513370} [modify] https://crrev.com/c0d29093152f07f215c996b6576b9ed288ddefbe/ui/gl/generate_bindings.py [modify] https://crrev.com/c0d29093152f07f215c996b6576b9ed288ddefbe/ui/gl/gl_bindings_autogen_gl.cc [modify] https://crrev.com/c0d29093152f07f215c996b6576b9ed288ddefbe/ui/gl/gl_bindings_autogen_mock.cc [modify] https://crrev.com/c0d29093152f07f215c996b6576b9ed288ddefbe/ui/gl/gl_bindings_autogen_mock.h
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe commit 3d0a6b53e6786dce889c6bf5b06ee100e8250bbe Author: Antoine Labour <piman@chromium.org> Date: Thu Nov 02 16:18:20 2017 Coalesce and extend bindings for MSAA rendering extensions There are 2 styles of MSAA rendering extensions: the GL3/ES3 core semantics (also supported by GL_ARB_framebuffer_object, GL_EXT_framebuffer_multisample + GL_EXT_framebuffer_blit, and GL_ANGLE_framebuffer_multisample), as well as the GL_EXT/IMG_multisampled_render_to_texture style. This CL coalesces the bindings for all extensions in each of the styles, which greatly simplifies the code. glBlitFramebuffer/glRenderbufferStorageMultisample bindings are used for the core style one (or ARB/EXT version), whereas glFramebufferTexture2DMultisampleEXT/glRenderbufferStorageMultisampleEXT are used for the multisampled_render_to_texture style. It also picks up the bindings when GL_ARB_framebuffer_object is supported (which Skia expects) Bug: 780320 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idf474978e579332348532cc2f7884f17f1e12963 Reviewed-on: https://chromium-review.googlesource.com/750197 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513506} [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/context_group.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/create_gr_gl_interface.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/feature_info.h [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/feature_info_unittest.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/gpu/command_buffer/service/test_helper.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/generate_bindings.py [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_bindings_api_autogen_gl.h [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_bindings_autogen_gl.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_bindings_autogen_gl.h [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_bindings_autogen_mock.cc [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_mock_autogen_gl.h [modify] https://crrev.com/3d0a6b53e6786dce889c6bf5b06ee100e8250bbe/ui/gl/gl_stub_autogen_gl.h
,
Nov 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by piman@chromium.org
, Nov 1 2017