New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780318 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 641470



Sign in to add a comment

VR: Implement editable input field for UI elements

Project Member Reported by ymalik@chromium.org, Oct 31 2017

Issue description

The omnibox will require an editable text field. We should have a generic element that the omnibox can use. 
 

Comment 1 by ymalik@chromium.org, Oct 31 2017

Blockedon: 641470

Comment 2 by ymalik@chromium.org, Oct 31 2017

Blockedon: -641470
Blocking: 641470
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d862b31c76a0c0f674df51105eedd2cde0776e29

commit d862b31c76a0c0f674df51105eedd2cde0776e29
Author: Yash Malik <ymalik@google.com>
Date: Sat Dec 02 02:09:32 2017

VR: Introduce keyboard as element

This CL introduces the notion of input focus and adds plumbing
between the GVR Keyboard and our UI. It adds functionality for
showing the keyboard on input text focus, and updating the said
input text model when the user types on the keyboard.

Bug: 780135, 780318 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I91c02e2de8b96703307c6f37436ef107d5b5dd07
Reviewed-on: https://chromium-review.googlesource.com/786302
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521179}
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/gvr_keyboard_delegate.cc
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/gvr_keyboard_delegate.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/gvr_util.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/gvr_util.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/keyboard.cc
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/keyboard.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/text_input.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/elements/ui_texture.h
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/keyboard_delegate.h
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/keyboard_ui_interface.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/model/model.h
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/model/text_input_info.cc
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/testapp/vr_test_context.cc
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/text_input_delegate.cc
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/text_input_delegate.h
[add] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/text_input_unittest.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_renderer.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/d862b31c76a0c0f674df51105eedd2cde0776e29/chrome/browser/vr/ui_unittest.cc

Comment 4 by ymalik@chromium.org, Dec 18 2017

This is fixed with the CL above and https://chromium-review.googlesource.com/c/chromium/src/+/786112

Comment 5 by ymalik@chromium.org, Dec 18 2017

Status: Fixed (was: Available)

Sign in to add a comment