Issue 780298 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	dougarnett@chromium.org
Closed:	Nov 2017
Cc:	bengr@chromium.org
Components:	Blink>Previews
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Feature

Blocking:
issue 801275

Add Whitelist support for deciding NoScript preview

Project Member Reported by dougarnett@chromium.org, Oct 31 2017

Issue description

Add whitelist check for NoScript in ShouldAllowPreviewAtECT if optimization hints are enabled and as long as other constraints are satisfied.


This is follow-on work from  issue 773834

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3240db56de8eb8a4cf3c913872545192e01b2083

commit 3240db56de8eb8a4cf3c913872545192e01b2083
Author: Doug Arnett <dougarnett@chromium.org>
Date: Fri Nov 03 17:36:24 2017

Adds new PreviewsOptimizationGuide whitelist interface

Bug:  780298 
Change-Id: Ia369ee168a5f297515048944f2339c7fcebb904f
Reviewed-on: https://chromium-review.googlesource.com/740672
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513824}
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/BUILD.gn
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_experiments.cc
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_experiments.h
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_io_data.cc
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_io_data.h
[modify] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_io_data_unittest.cc
[add] https://crrev.com/3240db56de8eb8a4cf3c913872545192e01b2083/components/previews/core/previews_optimization_guide.h