Validate Printer Addresses during setup |
||||
Issue descriptionCurrently, we don't validate printer addresses allowing users to enter some odd and invalid values. Help the user by doing some validation. Improving user friendliness as a follow up to: crbug.com/778383
,
Dec 1 2017
,
Dec 1 2017
We'd like to add a check during setup that ensures the uri is valid. There does not appear to be a really good way to do this in javascript. We'd also like to add a check in the javascript but that can be completed separately.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b992fb57cbd2064f7895a2af938a39e35c17a1a2 commit b992fb57cbd2064f7895a2af938a39e35c17a1a2 Author: David Valleau <valleau@chromium.org> Date: Thu Dec 14 21:34:07 2017 Adding verification of user-entered addresses R=hcarmona@chromium.org, skau@chromium.org Bug: 780284 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9508803a34cde2c957cf4ca03047990039e3a29 Reviewed-on: https://chromium-review.googlesource.com/809536 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#524185} [modify] https://crrev.com/b992fb57cbd2064f7895a2af938a39e35c17a1a2/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/b992fb57cbd2064f7895a2af938a39e35c17a1a2/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js [modify] https://crrev.com/b992fb57cbd2064f7895a2af938a39e35c17a1a2/chrome/test/data/webui/settings/cups_printer_page_tests.js
,
Dec 14 2017
,
Jul 30
|
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Oct 31 2017