New issue
Advanced search Search tips

Issue 780277 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Time settings don't take effect

Project Member Reported by michae...@chromium.org, Oct 31 2017

Issue description

Chrome Version: 62.0.3202.55

Note: I'm currently on a gogoinflight captive portal which may or may not be affecting Chrome OS's time tracking behavior.

What steps will reproduce the problem?
1. Open Date and Time settings
2. Enable "Use 24-hour clock". The clock in the shelf is still showing "5:53" instead of "17:53". (Reloading the page shows that the setting itself did change.)
3. Click "Set date and time". (Normally this should be disabled, so the fact that it's available suggests CrOS hasn't been able to sync the time.)
4. In the dialog, change the time and hit Done. The time is not changed; launching the dialog again shows the original time.

I'm not sure whether these issues are related, but it seems likely.
 
Cc: afakhry@chromium.org
Hrm, interesting.

1. Do you have "Set time zone automatically" enabled?
2. Is this a corp/managed device?
3. Can you try it again when you're not on gogo?

I could imagine the timezone detection failing if your network is weird. I think Ahmed added logging for that, so it might show up in a feedback report, or in about:system UI logs.

Cc: steve...@chromium.org
1. Yes, but the issue is the same without it enabled.
2. Yes, and signed in with my corporate account. I also have a secondary user signed in but that shouldn't affect the primary user's Settings page.
3. It has the same behavior on my hotel WiFi (though that's also weird). Won't have normal WiFi for a few days.

Weird: The secondary user's "Use 24 hour clock" setting does take effect for that user. And, as intended, switching to and from that user's desktop changes the clock format. Only the primary (corp) account is unable to enable 24-hour time, even if that account's "settings.clock.use_24hour_clock" pref is set to true.

I have an update pending, but I kinda want to debug this a bit more before seeing if it persists after a restart.

This is a samus.

Feedback: http://feedback/#/Report/80009709660

tlsdate logs:

2017-10-31T20:31:14.366311-07:00 INFO tlsdated[2866]: [event:action_kickoff_time_sync] clock delta desync detected (1509417926 != 1509439445)
2017-10-31T20:31:14.366327-07:00 NOTICE tlsdate[2867]: [event:action_kickoff_time_sync] clock delta desync detected (1509417926 != 1509439445)
2017-10-31T20:31:46.368713-07:00 INFO tlsdated[2866]: [event:action_resolve_proxy] resolving proxy for clients3.google.com:443
2017-10-31T20:31:46.368783-07:00 NOTICE tlsdate[2867]: [event:action_resolve_proxy] resolving proxy for clients3.google.com:443
2017-10-31T20:31:47.372906-07:00 INFO tlsdated[2866]: [event:action_run_tlsdate] attempt 1 backoff 10
2017-10-31T20:31:47.373108-07:00 NOTICE tlsdate[2867]: [event:action_run_tlsdate] attempt 1 backoff 10
2017-10-31T20:31:47.379633-07:00 NOTICE tlsdate[2867]: V: tlsdate version 0.0.5
2017-10-31T20:31:47.379671-07:00 NOTICE tlsdate[2867]: V: We were called with the following arguments:
2017-10-31T20:31:47.379689-07:00 NOTICE tlsdate[2867]: V: validate SSL certificates host = clients3.google.com:443
2017-10-31T20:31:47.383410-07:00 NOTICE tlsdate[2867]: V: time is currently 1509507107.383232325
2017-10-31T20:31:47.383431-07:00 NOTICE tlsdate[2867]: V: time is greater than RECENT_COMPILE_DATE
2017-10-31T20:31:47.386843-07:00 NOTICE tlsdate[2867]: V: using TLSv1_client_method()
2017-10-31T20:31:47.387038-07:00 NOTICE tlsdate[2867]: V: opening socket to clients3.google.com:443
2017-10-31T20:31:48.097710-07:00 NOTICE tlsdate[2867]: V: freezing time for x509 verification
2017-10-31T20:31:48.097723-07:00 NOTICE tlsdate[2867]: V: remote peer provided: 1509507108, preferred over compile time: 1507870510
2017-10-31T20:31:48.097731-07:00 NOTICE tlsdate[2867]: V: freezing time with X509_VERIFY_PARAM_set_time
2017-10-31T20:31:49.866593-07:00 NOTICE tlsdate[2867]: V: certificate verification passed
2017-10-31T20:31:49.866633-07:00 NOTICE tlsdate[2867]: V: commonName mismatch! Expected: clients3.google.com - received: *.google.com
2017-10-31T20:31:49.866657-07:00 NOTICE tlsdate[2867]: V: found non subjectAltName extension
2017-10-31T20:31:49.866969-07:00 NOTICE tlsdate[2867]: V: Inspecting 'clients3.google.com' for possible wildcard match against '*.google.com'
2017-10-31T20:31:49.866987-07:00 NOTICE tlsdate[2867]: V: label found; total label count: 1
2017-10-31T20:31:49.867003-07:00 NOTICE tlsdate[2867]: V: label found; total label count: 2
2017-10-31T20:31:49.867017-07:00 NOTICE tlsdate[2867]: V: label found; total label count: 3
2017-10-31T20:31:49.867031-07:00 NOTICE tlsdate[2867]: V: Found wildcard in at start of provided certificate name
2017-10-31T20:31:49.867044-07:00 NOTICE tlsdate[2867]: V: Attempting match of 'clients3' against '*'
2017-10-31T20:31:49.867058-07:00 NOTICE tlsdate[2867]: V: Forced match of 'clients3' against '*'
2017-10-31T20:31:49.867072-07:00 NOTICE tlsdate[2867]: V: Attempting match of 'google' against 'google'
2017-10-31T20:31:49.867086-07:00 NOTICE tlsdate[2867]: V: Attempting match of 'com' against 'com'
2017-10-31T20:31:49.867099-07:00 NOTICE tlsdate[2867]: V: remaining labels match!
2017-10-31T20:31:49.867114-07:00 NOTICE tlsdate[2867]: V: wildcard match of clients3.google.com against *.google.com
2017-10-31T20:31:49.867128-07:00 NOTICE tlsdate[2867]: V: hostname verification passed
2017-10-31T20:31:49.867141-07:00 NOTICE tlsdate[2867]: V: public key is ready for inspection
2017-10-31T20:31:49.867153-07:00 NOTICE tlsdate[2867]: V: key type: EVP_PKEY_RSA
2017-10-31T20:31:49.867166-07:00 NOTICE tlsdate[2867]: V: keybits: 2048
2017-10-31T20:31:49.867179-07:00 NOTICE tlsdate[2867]: V: key length appears safe
2017-10-31T20:31:49.867363-07:00 NOTICE tlsdate[2867]: V: server time 1509507108 (difference is about -1 s) was fetched in 2484 ms
2017-10-31T20:31:49.867381-07:00 NOTICE tlsdate[2867]: V: the TLS handshake took more than 2000 msecs - consider using a different server or run it again
2017-10-31T20:31:48.000239-07:00 INFO tlsdated[2866]: [event:handle_child_death] tlsdate reaped => pid:18092 uid:234 status:0 code:1
2017-10-31T20:31:48.000240-07:00 NOTICE tlsdate[2867]: [event:handle_child_death] tlsdate reaped => pid:18092 uid:234 status:0 code:1
2017-10-31T20:31:48.000679-07:00 INFO tlsdated[2866]: [event:handle_time_setter] time set from the network (1509507108)
2017-10-31T20:31:48.000695-07:00 NOTICE tlsdate[2867]: [event:handle_time_setter] time set from the network (1509507108)
2017-10-31T20:40:29.535663-07:00 INFO tlsdated[2866]: [event:handle_set_time]: time is already synchronized.
2017-10-31T20:40:29.535720-07:00 NOTICE tlsdate[2867]: [event:handle_set_time]: time is already synchronized.
2017-10-31T20:40:35.857714-07:00 INFO tlsdated[2866]: [event:handle_set_time]: time is already synchronized.
2017-10-31T20:40:35.857764-07:00 NOTICE tlsdate[2867]: [event:handle_set_time]: time is already synchronized.

Which suggests the dialog should not be enabled, so that part might just be a Settings regression.
Cc: abodenha@chromium.org
I'm seeing a settings problem - manually setting the time does not work.

Google Chrome	62.0.3202.74 (Official Build) beta (64-bit)
Platform	9901.54.0 (Official Build) beta-channel samus
Enterprise enrolled

* Open Settings > Date and Time
* Make sure "set time automatically" is unchecked
* Set the time to 1:11 AM, click "Done"

Shelf clock does not change. Reopening the dialog shows the old time, not the new time.

I did touch the 24-hour time code for mustash, but that was a year ago. Also, toggling 24 hour time does change the shelf display for me.

Who would be a good person to look at the settings issue?

Screenshot 2017-11-01 at 8.23.17 AM.png
46.5 KB View Download
Screenshot 2017-11-01 at 8.23.31 AM.png
55.7 KB View Download
Screenshot 2017-11-01 at 8.23.37 AM.png
14.9 KB View Download
Screenshot 2017-11-01 at 08.23.45.png
15.1 KB View Download
(Also, switching between 2 multiprofile users with different 24-hour time settings does work for me; the shelf clock updates.)

Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
I think Alex worked on time settings.
Manually setting the time should NOT work if tlsdate has managed to acquire a network time, which is the normal case. The dialog may be viewable soon after startup or if you're on a weird network, but normally it shouldn't be accessible. Chrome can't manually override tlsdate if tlsdate has a network time.

Assuming that's the case, the issue is that the dialog is allowed to open; changing the time should not take effect unless we haven't synced the time since boot.
I've confirmed that setting the time from Settings works as expected when I disable my network before booting. However, the clock in the shelf does not update until the next "minute" passes; it shows the old time until the time changes to (time I set + 1 minute).

You can verify the device's time has changed by looking at the result of new Date() in a JS console. So the shelf is slow to update here.

(I'm still seeing that the Set Time dialog can be shown even when it *can't* take effect, which is a Settings bug.)

Comment 8 by vadimt@chromium.org, Nov 27 2017

Labels: Not-Touch-Friendly-Launcher
Components: -UI>Shell>Shelf

Sign in to add a comment