New issue
Advanced search Search tips

Issue 780273 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 773793



Sign in to add a comment

Back button shows up on interstitial when there's no page to navigate back to

Project Member Reported by ntfschr@chromium.org, Oct 31 2017

Issue description

I think I saw this when trying to repro issue 779205.

The basic idea is:

0. Use the --webview-safebrowsing-block-all-resources flag
1. Open Google Photos, tap menu, tap Help
2. Click one of the links
3. Observe that there is no back button (expected)
4. Click Android's back button to get out of the interstitial
5. Click a link again
6. Observe that there *is* a back button on the interstitial (unexpected)

Clicking the "back to safety" button on the 2nd interstitial causes a crash (which makes sense, there's nothing to go back to). I can't quite remember, but I think we hit a DCHECK violation.

---

I'll update this bug if I've written anything erroneous.
 
This is marked as RBS. M64 Feature freeze on next Friday(11/10). Could we have some update on this? 

Thanks!
Labels: -Pri-2 Pri-1

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -M-64 M-65
Cc: changwan@chromium.org
Labels: -M-65 M-66
Unfortunately won't have time to get this for M65
Labels: -Pri-1 Pri-2
A quick follow-up: I've only reproduced this with the --block-all-resources flag, I don't think this is a case which real users will hit often.

This bug requires:

 - hitting at least 2 interstitials within the same session of using the app
 - the webview must be destroyed & recreated at least once
 - both safe browsing hits must be on the "initial navigation" for the webview (the first URL load after it is (re)created)

Hitting all these conditions seems unlikely in practice, so I'm lowering the priority.

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
It is marked as RBS, could we have some update here?
Thanks!

Labels: -ReleaseBlock-Stable -M-66 M-67
I'll investigate this during 67. I'm still pretty confident most users won't see this crash.
Labels: -M-67 Valid-Difficult-Fix
I have no clue as to root cause, but this is probably something we should eventually fix.
Labels: -Pri-2 Pri-3

Sign in to add a comment