New issue
Advanced search Search tips

Issue 780267 link

Starred by 1 user
Status: Fixed
Owner:
mattreynolds@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Track usage of Geolocation methods with UseCounter

Project Member Reported by mattreynolds@chromium.org, Oct 31 2017 
It would be helpful for us to understand how the Geolocation API is used by tracking usage with UseCounter. We should add MeasureAs IDL attributes to enable these metrics. For instance:

[MeasureAs=GeolocationGetCurrentPosition] void getCurrentPosition( ...

[MeasureAs=GeolocationWatchPosition] void watchPosition( ...

Currently, these methods have the LogActivity attribute which appears to only enable local logging.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f634e30b9c80fc2a281542e27763a726f33fa3ca

commit f634e30b9c80fc2a281542e27763a726f33fa3ca
Author: Matt Reynolds <mattreynolds@google.com>
Date: Wed Nov 01 01:04:24 2017

Record usage of Geolocation API calls

Add MeasureAs attributes for geolocation methods so usage of the feature
can be tracked through UseCounter.

BUG= 780267 

Change-Id: I8994be04aa750971204f515d66f5834ce38ab8c8
Reviewed-on: https://chromium-review.googlesource.com/747862
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513031}
[modify] https://crrev.com/f634e30b9c80fc2a281542e27763a726f33fa3ca/third_party/WebKit/Source/modules/geolocation/Geolocation.idl
[modify] https://crrev.com/f634e30b9c80fc2a281542e27763a726f33fa3ca/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/f634e30b9c80fc2a281542e27763a726f33fa3ca/tools/metrics/histograms/enums.xml

Comment 2 by mattreynolds@chromium.org, Nov 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment