New issue
Advanced search Search tips

Issue 780263 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Figure out how to clang-format mojom files

Project Member Reported by dcheng@chromium.org, Oct 31 2017

Issue description

It's mostly C compatible, but it looks like it gets confused by a few things. I tried formatting content/common/frame.mojom, and a few odd looking lines:

This one is probably OK:
// See src/content/common/navigation_params.h                                                  [Native] struct CommonNavigationParams;

This one is probably not:
// An opaque handle that keeps alive the associated render process even after                  
// the frame is detached. Used by resource requests with "keepalive" specified.                
interface KeepAliveHandle{};

And this one is definitely not:
interface FrameFactory {                       
  CreateFrame(int32 frame_routing_id, Frame & frame);                                          
};
 

Comment 1 by dcheng@chromium.org, Oct 31 2017

nick@ points out that replacing 'interface' with 'class' will fix the ampersand formatting issue, though mojo method definitions don't get rewrapped (probably because there's no return type / it's confused by the arrow return)
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 1

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Hotlist-Recharge-Cold Pri-2
Status: Available (was: Untriaged)

Sign in to add a comment