New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780221 link

Starred by 2 users
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 773754



Sign in to add a comment

Implement recognition failed UI

Project Member Reported by bshe@chromium.org, Oct 31 2017 
If speech engine failed to recognize a speech (i.e. due to random noise), we should have UI to make it clear to user that speech recognition failed and they can try again if they want.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/537a72966182a2c5240dff71283a530fc9263596

commit 537a72966182a2c5240dff71283a530fc9263596
Author: Biao She <bshe@chromium.org>
Date: Fri Nov 10 18:18:42 2017

Show text for a short time before hide speech recognition UI (text could be speech recognition result or error string)


Bug:  779783 , 780221 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id7fb31a5b61de7f0b6142b0f4b3b945f24dab9c9
Reviewed-on: https://chromium-review.googlesource.com/762787
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515603}
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/app/generated_resources.grd
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/model/model.h
[add] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/model/speech_recognition_model.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/speech_recognizer.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui_renderer_unittest.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui_scene_manager.h
[modify] https://crrev.com/537a72966182a2c5240dff71283a530fc9263596/chrome/browser/vr/ui_scene_manager_unittest.cc

Comment 2 by bshe@chromium.org, Nov 10 2017

Status: Fixed (was: Assigned)

Comment 3 by dougman@chromium.org, Feb 7 2018

Labels: Test-Manual

Comment 4 by dougman@chromium.org, Feb 7 2018

Labels: Test-Manual
►

Sign in to add a comment