New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780202 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.7% regression in system_health.memory_desktop at 511130:511413

Project Member Reported by briander...@chromium.org, Oct 31 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 31 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=780202

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d4123dbd049e35ac05697a9aed17bba584fbceae5d3eec33b3d59858ba0fa740


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 31 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_chrome/load_chrome_blank

Revision             Result                   N
chromium@511129      10333224 +- 115477       21      good
chromium@511413      10323660 +- 29601.3      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964185945345460560


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 31 2017

Cc: zmo@chromium.org
Owner: zmo@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author zmo@chromium.org ===

Hi zmo@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Zhenyao Mo
  Commit : 77604d4d295b16c91b935c0a3e035a574532a497
  Date   : Mon Oct 30 03:22:48 2017
  Subject: Call UpdateGPUInfo and UpdateGpuFeatureInfo always on GPU process launch.

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_chrome/load_chrome_blank
  Change       : 4.10% | 10396112.6667 -> 10822052.6667

Revision             Result                   N
chromium@512424      10396113 +- 15752.6      6      good
chromium@512433      10405165 +- 21991.6      6      good
chromium@512434      10403494 +- 6680.06      6      good
chromium@512435      10812457 +- 39961.3      6      bad       <--
chromium@512436      10812519 +- 43614.1      6      bad
chromium@512438      10809695 +- 41501.6      6      bad
chromium@512442      10822053 +- 38424.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964185910863800080


For feedback, file a bug with component Speed>Bisection

Comment 6 by zmo@chromium.org, Nov 1 2017

Owner: ----
Status: Available (was: Assigned)
This CL was reverted as part of https://chromium-review.googlesource.com/c/chromium/src/+/743741

If the perf doesn't recover, then another CL is responsible.
Status: Fixed (was: Available)
It did recover in the range of the CL for the revert in #6.
Cc: mlippautz@google.com
 Issue 781150  has been merged into this issue.
Cc: mlippautz@chromium.org
 Issue 781197  has been merged into this issue.
 Issue 781156  has been merged into this issue.

Sign in to add a comment