New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780188 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.8% regression in blink_perf.dom at 511034:511067

Project Member Reported by briander...@chromium.org, Oct 31 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 31 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=780188

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0d1247e94501501b2c211fa12ccb7af065bab766a64c3d9db9154bd3c294f7ba


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel

=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.dom
  Metric       : select-single-add/select-single-add
  Change       : 5.89% | 2344.47999816 -> 2451.26356368

Suspected Commit Range
  4 commits in range
  https://chromium.googlesource.com/chromium/src/+log/4863cd0207a8f643205d3c2c4e4ade6c502922b2..012769532c3d31254d7730d4a64613982fde241f


Revision             Result                  N
chromium@511033      2344.48 +- 324.593      14       good
chromium@511034      ---                     ---      build failure
chromium@511035      ---                     ---      build failure
chromium@511036      ---                     ---      build failure
chromium@511037      2542.48 +- 70.3445      14       bad
chromium@511038      2509.71 +- 242.097      14       bad
chromium@511042      2549.48 +- 162.567      6        bad
chromium@511050      2497.57 +- 42.4846      6        bad
chromium@511067      2451.26 +- 171.094      9        bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.dom

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8964186482738199520


For feedback, file a bug with component Speed>Bisection
Retrying on a wider range with pinpoint. Might be multiple regressions?
One suspect CL is the wider range is "win: Re-enable Clang by default" [1]. I wouldn't be surprised that switching compiler on windows affects this benchmark.

Also current pinpoint result so far seems to suggest this. Let's wait for it to finish though.

[1] https://chromium.googlesource.com/chromium/src/+/22525134c75ca2a005997a717f6887a23af86210
Status: WontFix (was: Untriaged)
Looks like this test actually showed small performance changes at several CLs, so many that the bisect didn't complete. Not much more can be done I think.

Sign in to add a comment