Replace with various indirections over mus. Mash can not directly access WindowState.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1bfc6f9e4c43a19000b16207eb95259eef09522 commit c1bfc6f9e4c43a19000b16207eb95259eef09522 Author: Elliot Glaysher <erg@chromium.org> Date: Wed Nov 01 20:44:48 2017 Move window position managed to an aura::Window property. This changes management of the window position from booleans which live on ash::wm::WindowState to general aura Window properties. These can be set from //chrome/ without having to link with the non-public parts of //ash/. Bug: 780160 Change-Id: I834c268dcf333576bf88a24f99d388cf9732a9e5 Reviewed-on: https://chromium-review.googlesource.com/747876 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513255} [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/mus/window_manager.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/public/cpp/window_properties.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/public/cpp/window_properties.h [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/public/interfaces/BUILD.gn [add] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/public/interfaces/window_properties.mojom [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/shell/toplevel_window.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/toplevel_window_event_handler.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/window_positioner.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/window_state.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/window_state.h [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/window_state_unittest.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/chrome/browser/ui/views/frame/browser_frame_ash.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/c1bfc6f9e4c43a19000b16207eb95259eef09522/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b372ee596386c0a0d322492a3899dce68edbb07b commit b372ee596386c0a0d322492a3899dce68edbb07b Author: Elliot Glaysher <erg@chromium.org> Date: Thu Nov 09 19:34:13 2017 Pass whether the window can consume system keys as a property. This replaces a bool on ash::wm::WindowState with an aura::Window property. Bug: 780160 Change-Id: I1537071cb1dcc985bd6757c906dfe3e87acda356 Reviewed-on: https://chromium-review.googlesource.com/752484 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515243} [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/accelerators/accelerator_router.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/mus/window_manager.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/public/cpp/window_properties.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/public/cpp/window_properties.h [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/public/interfaces/window_properties.mojom [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/wm/window_state.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/wm/window_state.h [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/ash/wm/window_state_unittest.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/chrome/browser/ui/views/frame/browser_frame_ash.cc [modify] https://crrev.com/b372ee596386c0a0d322492a3899dce68edbb07b/chrome/browser/ui/views/frame/browser_frame_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/614a167430f1d98750f07116c945238103ad861e commit 614a167430f1d98750f07116c945238103ad861e Author: Elliot Glaysher <erg@chromium.org> Date: Mon Nov 27 21:12:21 2017 [mash] Use an aura::Window property for hide shelf in fullscreen mode. This removes another direct usage of ash::wm::WindowState from //chrome/. It also reworks the signaling mechanism in ImmersiveModeControllerAsh so that on fullscreen change events, we correctly update the shelf visibility without directly linking with ash code. Bug: 780160, 640384 Change-Id: I0539d37639974f0c170306dc1dcbcd26389faf97 Reviewed-on: https://chromium-review.googlesource.com/758974 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519403} [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/cpp/window_properties.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/cpp/window_properties.h [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/public/interfaces/window_properties.mojom [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/session/session_controller.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/system/web_notification/fullscreen_notification_blocker.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/window_state.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/ash/wm/window_state.h [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/614a167430f1d98750f07116c945238103ad861e/components/exo/shell_surface.cc
Mass unassigning bugs
Issue 855096 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Nov 1 2017