New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780146 link

Starred by 38 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Keyboard shortcuts are not working when all windows are minimized

Project Member Reported by sdantul...@chromium.org, Oct 31 2017

Issue description

Google Chrome   63.0.3239.26 (Official Build) dev (64-bit)
Revision        0
Platform        10032.21.0 (Official Build) dev-channel eve

Steps:
1. Make sure all the opened windows are minimized
2. Press Search key to open launcher. Press Ctrl+n, Ctrl+t, or menu key

Result:
Nothing happens. 

This issue is not seen when any app window is open. Only repro'd when all windows are minimized.

Filed feedback report from the device but unable to see it in "https://feedback.corp.google.com/"
Feedback is titled along the lines of "Keyboard shortcuts are not working..."
 
Cc: allendam@chromium.org
This issue is also being reported in the Google Pixelbook Help forum
https://productforums.google.com/forum/#!topic/pixelbook/YFLqFajycsc
I'm on -
- Version: 62.0.3202.74 (Official Build) (64-bit)
- Platform: 9901.54.0 (Official Build) stable-channel eve
And cannot repo. with windows minimized or CLOSED.

Perhaps it's a regression?
Update: Ignore #c4, I've been bit by it now too it seems.

Comment 6 by shan...@gmail.com, Nov 4 2017

this happens on dev channel. Actually after the update yesterday seems to be working, however tried again this afternoon and no luck, launcher or settings not open


Screenshot 2017-11-04 at 18.11.59.png
118 KB View Download
Saw this issue on Chrome OS: 10032.30.0, 63.0.3239.39 beta build on eve. Exact repro steps are not known. But, I was working with N-apps and pre-N apps, maximizing and minimizing them on external monitor connected. While these apps were opened, I was trying to switch between tablet mode and back to normal mode with external monitor connected. Launcher key, menu key buttons were not working.

Relevant logs are attached in this link:
https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/780146/
Owner: yhanada@chromium.org
Status: Assigned (was: Untriaged)
Now being reported on Chromebook Central
https://productforums.google.com/forum/#!topic/chromebook-central/491Sw00vz8w

CBC-RS/TC-watchlist
Feedback report link for the original repro in c#0 http://feedback/#/Report/79845022494
I am on "Version 62.0.3202.97 (Official Build) (64-bit)" using a Samsung Chromebook Pro. Here is how to break the search key. (1) Close every app, nothing should be running including the browser. (2) Go into tablet mode. (3) Engage or click on the status area. (4) Go back into laptop mode. (5) Start hitting the search key; it may work once but will then no longer work.

This can be done in guest mode.

The only way to get it working again is to do a chrome://restart or restart the device. Loggin out and back in will do the trick as well. ALSO, as said before if you leave a app running everything works fine.

I have a video if anyone is interested.

Comment 13 by dymp...@gmail.com, Jan 7 2018

Reproduced on Caroline V64. Keyboard shortcuts do not work without active browser window/tab. Worked on V62 and V63.

Google Chrome	64.0.3282.41 (Official Build) beta (64-bit)
Revision	0
Platform	10176.22.0 (Official Build) beta-channel caroline
Firmware Version	Google_Caroline.7820.349.0
Customization ID	SAMSUNG-CAROLINE
ARC	4510202
JavaScript	V8 6.4.388.9
Flash	28.0.0.133 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; CrOS x86_64 10176.22.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.41 Safari/537.36

Still works on Yuna.

Google Chrome	64.0.3282.41 (Official Build) beta (64-bit)
Revision	0
Platform	10176.22.0 (Official Build) beta-channel auron_yuna
Firmware Version	Google_Auron_yuna.6301.59.116
Customization ID	YUNA
ARC	4510202
JavaScript	V8 6.4.388.9
Flash	28.0.0.133 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; CrOS x86_64 10176.22.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.41 Safari/537.36

Comment 14 by dymp...@gmail.com, Jan 8 2018

Feedback sent 7:37 am ET 
Issue# 780146 Keyboard shortcuts are not working when all windows are minimized

Can only reproduce after NOT signing out or rebooting for 24 hours > close lid in pm.

AM-only right after opening the lid after 10 hours sleep.

Keyboard shortcuts started working again while looking up this bug and typing feedback.

edit comment#13. Shutdown > restart fixed the non working keyboard shortcuts.

Comment 15 by dymp...@gmail.com, Jan 8 2018

OK, the reason shortcuts started working again was because the Hangouts app loaded.

1. Hangout app > transparent setting > icon on the screen on the right > shortcuts work

2. close HO app > shortcuts do not work

Feedback sent 7:48 am ET

 Issue#780146  comment#14



Labels: -Pri-2 Pri-1
Bumping to P1 given number of reports.

yhanada@ are you the correct owner for this?
Cc: afakhry@chromium.org
Status: Started (was: Assigned)
+afakhry

It might be related to recent my changes around keyboard shortcut handling in ARC++ apps, so I want to make sure that it's not caused by my changes.

Re#17: Sounds good. Thanks!
I tested the scenario in comment 12 and succeeded to reproduce the issue.
When I do the repro steps, an anonymous window under SettingBubbleContainer is set to a target of key events instead of RootWindow.
It changes the result of AcceleratorRouter::ShouldProcessAcceleratorNow[1] and stops shortcuts from working.
I believe that my changes are not related to at least this case.

I haven't tested the scenario in comment 14.

[1]: https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_router.cc?type=cs&l=110
Cc: minch@chromium.org
The anonymous window I mentioned above is a window created in [1]. The window remains after closing the bubble and exiting tablet mode.

+minch@, who wrote this part,
I guess that this window should be deleted after closing the bubble. What do you think?

[1]: https://cs.chromium.org/chromium/src/ash/system/tray/tray_background_view.cc?type=cs&l=495
Cc: est...@chromium.org

Comment 22 by minch@chromium.org, Jan 12 2018

Re#20, I can repro the scenario in comment 12 too. Yup, we will not delete the |clipping_window_| after create it even close the bubble, it has the same lifetime as the TrayBackgroudView (SystemTray etc.,) instance. Let me take a look of this. Thanks.
Cc: yhanada@chromium.org
Owner: minch@chromium.org
Status: Assigned (was: Started)

Comment 24 by minch@chromium.org, Jan 16 2018

Status: Started (was: Assigned)
Cc: warx@chromium.org
Issue 804031 has been merged into this issue.
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da848713fa8943a1f3063d2cf08150df99743227

commit da848713fa8943a1f3063d2cf08150df99743227
Author: MinChen <minch@chromium.org>
Date: Wed Jan 24 17:38:56 2018

cros: Dont create clipping window if no drag controller is set.

Test: SystemTrayTest.ToggleAppListAfterOpenSystemTrayBubbleInTabletMode
Bug:  780146 
Change-Id: I37444aabbd781961381934b57954ec4c614fc99b
Reviewed-on: https://chromium-review.googlesource.com/882288
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531589}
[modify] https://crrev.com/da848713fa8943a1f3063d2cf08150df99743227/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/da848713fa8943a1f3063d2cf08150df99743227/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/da848713fa8943a1f3063d2cf08150df99743227/ash/system/tray/tray_background_view.h

Comment 28 by minch@chromium.org, Jan 30 2018

Labels: Merge-Request-65
The cl merged to TOT will fix the issue since M63. Will request merge back to M65 first.
If we want to fix the issue in M61 and M62, we may need another cl, but I am not sure can we still merge back to M62 and M61 now?
Project Member

Comment 29 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 30 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67df52dad72801dcd77503205467f7042b8ddc8f

commit 67df52dad72801dcd77503205467f7042b8ddc8f
Author: MinChen <minch@chromium.org>
Date: Wed Jan 31 18:47:23 2018

[Merge to M65]cros: Dont create clipping window if no drag controller is set.

TBR=minch@chromium.org

(cherry picked from commit da848713fa8943a1f3063d2cf08150df99743227)

Test: SystemTrayTest.ToggleAppListAfterOpenSystemTrayBubbleInTabletMode
Bug:  780146 
Change-Id: I37444aabbd781961381934b57954ec4c614fc99b
Reviewed-on: https://chromium-review.googlesource.com/882288
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531589}
Reviewed-on: https://chromium-review.googlesource.com/895057
Reviewed-by: min c <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#206}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/67df52dad72801dcd77503205467f7042b8ddc8f/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/67df52dad72801dcd77503205467f7042b8ddc8f/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/67df52dad72801dcd77503205467f7042b8ddc8f/ash/system/tray/tray_background_view.h

Comment 31 by minch@chromium.org, Jan 31 2018

Labels: Merge-Request-64
Project Member

Comment 32 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Rejected-64
This wasn't a M64 regression and we're already in stable.  Rejecting M64 request.
Status: Fixed (was: Started)
Cc: weidongg@chromium.org osh...@chromium.org
 Issue 812310  has been merged into this issue.
Cc: skuhne@chromium.org sky@chromium.org khmel@chromium.org jamescook@chromium.org
 Issue 780889  has been merged into this issue.
Issue 762155 has been merged into this issue.

Sign in to add a comment