heh, this probably _would_ happen on other platforms except it's a bug that keyboard shortcuts don't work correctly when bubbles are open - that's Issue 319109

I'll put this on Phase 3 to track, but I don't know if it's a true blocker.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6a9fa057e5f3ae5701acd457df6af34dc255f7

commit 5b6a9fa057e5f3ae5701acd457df6af34dc255f7
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Mar 07 16:25:01 2018

views: centralize LocationBarBubble close logic

This change:
1) Has LocationBarBubbleDelegateView close itself when the WebContents is
   hidden or closed;
2) Removes matching logic that was already in two of its subclasses;
3) Fixes the browser tests for one of those subclasses to allow for async
   window closure.

Bug:  780131 
Change-Id: I2362c82c89be1356356663789e97b51b3b2362f8
Reviewed-on: https://chromium-review.googlesource.com/919308
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541454}
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/intent_picker_bubble_view.cc
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/intent_picker_bubble_view.h
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/translate/translate_bubble_view.h
[modify] https://crrev.com/5b6a9fa057e5f3ae5701acd457df6af34dc255f7/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

This is Fixed by the CL in #3.

Argh, no it's not - it's fixed in the Views browser but not the Cocoa one. Reopening.

Pri-1 also since this is a secondary UI views regression.

No! Disregard me. I was testing with the wrong bubble. This does the right thing for content setting bubbles. *Bookmark* bubbles, which I was testing, don't hide - but that's expected since they aren't tied to a WebContents.

Unable to reproduce the issue with steps mentioned in comment#0 on reported version 64.0.3253.0. Hence unable to verify the fix on latest canary 67.0.3390.0. Attaching screencast of M-64 and M-67 for reference.

@ellyjones: Please help in verifying the fix.

Thanks!

Deleted: 780131.mp4 4.1 MB

	780131.mp4 4.1 MB View Download

#8:

This is a MacViews bug, so you need to turn on ShowAllDialogsWithViewsToolkit to test it. The dialog at 0:29 in your screencast is the pre-MacViews version of that dialog. Run Chrome with --enable-features=ShowAllDialogsWithViewsToolkit or flip chrome://flags#secondary-ui-md and chrome://flags#show-all-dialogs-with-views-toolkit both to Enabled.

As per comment#9 checked the issue by enabling chrome://flags#secondary-ui-md and chrome://flags#show-all-dialogs-with-views-toolkit. Issue is reproducible on reported version hence verifying the fix on latest canary 67.0.3396.0.

Now bubble dismisses on navigating to other tab using shortcut keys. Attaching screencast for reference.

As fix is working as expected adding verified labels and removing Needs-Feedback label.

Thanks!