New issue
Advanced search Search tips

Issue 780126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 611935
issue 776166



Sign in to add a comment

[mojo-blobs] Use SCOPED_BLINK_UMA_HISTOGRAM_TIMER_THREAD_SAFE in bink::BlobDataHandle

Project Member Reported by mek@chromium.org, Oct 31 2017

Issue description

BlobDataHandle is supposed to be thread safe, but currently uses non-thread safe logging macros. This should be fixed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25872fa648c91e05d1899b2e6c5c9daca9e8a46f

commit 25872fa648c91e05d1899b2e6c5c9daca9e8a46f
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Oct 31 20:19:38 2017

blink::BlobDataHandle should be thread safe, so use thread safe histogram.

Bug:  780126 
Change-Id: I22a0ca4cc6d856cb30cdc767d5135c21ccb4da90
Reviewed-on: https://chromium-review.googlesource.com/747123
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512931}
[modify] https://crrev.com/25872fa648c91e05d1899b2e6c5c9daca9e8a46f/third_party/WebKit/Source/platform/blob/BlobData.cpp

Comment 2 by mek@chromium.org, Nov 1 2017

Status: Fixed (was: Assigned)

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 5 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935

Sign in to add a comment