New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780110 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue monorail:2374
issue 801757



Sign in to add a comment

[Findit] Flake Analyzer - Use customized field for querying for bugs

Project Member Reported by wylieb@chromium.org, Oct 31 2017

Issue description

Currently we use a label, but once a customized field is available
through the monorail api, we should use that.
 

Comment 1 by wylieb@chromium.org, Nov 13 2017

Blockedon: 2374

Comment 2 by st...@chromium.org, Nov 13 2017

Blockedon: -2374 monorail:2374

Comment 3 by st...@chromium.org, Nov 13 2017

Status: Assigned (was: Untriaged)
FYI: if the blocking bug is in another project, so we need to prefix the project name like above.

Comment 4 by wylieb@chromium.org, Nov 13 2017

Ah, my bad.

Comment 5 by wylieb@chromium.org, Jan 13 2018

Blockedon: 801757
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2d91b6863d243990d79bbf8effea620b004de2ba

commit 2d91b6863d243990d79bbf8effea620b004de2ba
Author: Brandon Wylie <wylieb@chromium.org>
Date: Tue Feb 06 02:55:00 2018

[Findit] Instrument bug filing to use CustomFields instead of labels

Labels can be added and removed freely and easily, which makes them
an inefficient method to track long-lived information, and arbitrary
labels are generally discouraged in monorail. Since Findit wants
the information about Flaky Tests to stick around even after the
bug has been resolved, custom fields are a better way to track
test information for bugs.

When this change deploys, I'll manually port over any existing bugs.

Bug:780110
Change-Id: I4504c8b74c25e350c403a9b449b065c97b77c2df
Reviewed-on: https://chromium-review.googlesource.com/898064
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/2d91b6863d243990d79bbf8effea620b004de2ba/appengine/findit/services/flake_failure/issue_tracking_service.py
[modify] https://crrev.com/2d91b6863d243990d79bbf8effea620b004de2ba/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/2d91b6863d243990d79bbf8effea620b004de2ba/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/2d91b6863d243990d79bbf8effea620b004de2ba/appengine/findit/services/flake_failure/test/issue_tracking_service_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment