Media Controls: Loading: Spinner background when there is no poster |
||||||
Issue description
,
Nov 13 2017
,
Dec 19 2017
,
Jan 2 2018
It looks like the answer is here: https://docs.google.com/presentation/d/1wso086QMuxxSyIJPuuv2T5aJOn3Mlwo4c9KhfAdMdGw/edit#slide=id.g2689dcc3a4_0_3
,
Jan 10 2018
,
Jan 16 2018
Here are screencasts showing the before and after of crrev.com/c/865095
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c557d9ddb7aada575dd8cacdf65e70765f2ca2 commit 58c557d9ddb7aada575dd8cacdf65e70765f2ca2 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jan 17 15:23:40 2018 Set black background color on loading spinner when no frame available This CL sets the background color of the MediaControls loading spinner to black when no poster image or video frame is available. This solves an issue where the standard 50% opacity white spinner is not easily visible against the blank video background. Bug: 780047 Change-Id: I7940585797799c895a2bef8a209915b3b2d5aa75 Reviewed-on: https://chromium-review.googlesource.com/865095 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#529747} [modify] https://crrev.com/58c557d9ddb7aada575dd8cacdf65e70765f2ca2/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp [modify] https://crrev.com/58c557d9ddb7aada575dd8cacdf65e70765f2ca2/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.h [modify] https://crrev.com/58c557d9ddb7aada575dd8cacdf65e70765f2ca2/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_loading.css
,
Jan 17 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by beccahughes@chromium.org
, Nov 13 2017Owner: helenepark@chromium.org