New issue
Advanced search Search tips

Issue 780041 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 716053



Sign in to add a comment

[Dice] Handle unverified accounts

Project Member Reported by droger@chromium.org, Oct 31 2017

Issue description

Chrome needs to parse the "verified" bit from the ListAccounts Gaia endpoint, and handle unverified accounts in Dice.

Dice should not try to get a token for unverified accounts, and the AccountReconcilor should not logout these accounts.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b

commit e93b3b2a6df98509cf5ad2306aedb4b63a7c551b
Author: David Roger <droger@chromium.org>
Date: Wed Nov 15 17:15:15 2017

[signin] Parse "verified" bit from the ListAccounts Gaia endpoint

Gaia will add a "verified" bit for accounts in the ListAccounts
endpoint. This CL parses it, but does not use it yet.

As part of this CL the == operator on ListedAccount is removed,
because it was only used in tests, and was somewhat non-intuitive.

Bug:  780041 
Change-Id: Ie3b1610b4d6496bcb9d19f9b5887e90aba5167f2
Reviewed-on: https://chromium-review.googlesource.com/746924
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516728}
[modify] https://crrev.com/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
[modify] https://crrev.com/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b/google_apis/gaia/gaia_auth_util.cc
[modify] https://crrev.com/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b/google_apis/gaia/gaia_auth_util.h
[modify] https://crrev.com/e93b3b2a6df98509cf5ad2306aedb4b63a7c551b/google_apis/gaia/gaia_auth_util_unittest.cc

Comment 3 by droger@chromium.org, Nov 20 2017

Status: Fixed (was: Started)

Sign in to add a comment