New issue
Advanced search Search tips

Issue 780037 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 817099
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 780023



Sign in to add a comment

Committed interstitials: handle Proceed/GoBack for Supervised User interstitial

Project Member Reported by est...@chromium.org, Oct 31 2017

Issue description

For Supervised User committed interstitials, handling commands is pretty simple:
- Going back can be implemented by Javascript in the renderer as a simple back navigation.
- Proceed happens by events triggered in the browser process, e.g. when the URL filter changes. All that needs to happen for Proceed is that the page should be refreshed, but we need to know that a Supervised User page is showing so that we know to refresh. To do so:
  - When the SupervisedUserNavigationObserver generates a supervised user error page for a navigation, remember the navigation ID (we probably need to pass the ID as a parameter to OnRequestBlocked).
  - When the observer observes a committed navigation with a remembered navigation ID, set a flag to note that the currently committed navigation is a supervised user error page.
  - When we want to Proceed, refresh the page if the currently committed navigation is a supervised user error page (determined by the flag described above).
  - When a navigation finishes (DidFinishNavigation), we can clean up the remembered navigation ID for that navigation.
 

Comment 1 by est...@chromium.org, Oct 31 2017

Blockedon: 780023

Comment 2 by est...@chromium.org, Oct 31 2017

Blockedon: -780023
Blocking: 780023

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Comment 5 by est...@chromium.org, Mar 16 2018

Cc: est...@chromium.org
Owner: carlosil@chromium.org
Mergedinto: 817099
Status: Duplicate (was: Assigned)

Sign in to add a comment