New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780036 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Investigate Metrics Files Not Being Uploaded

Project Member Reported by bcwh...@chromium.org, Oct 31 2017

Issue description

There are a significant number of metrics files removed as "cleanup" when they should have been uploaded.

https://uma.googleplex.com/p/chrome/timeline_v2/?sid=163d1e2576c1f5d1d820a16090769727

Find out why.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514d9f3232687f8eb35ffa74993d1b5ad2a0b219

commit 514d9f3232687f8eb35ffa74993d1b5ad2a0b219
Author: Brian White <bcwhite@chromium.org>
Date: Tue Dec 05 19:02:26 2017

Better handling of invalid files in metrics directory.

Previously, when managing a directory of files, only one file was ever
processed per call.  This wasn't a problem because after each call,
another would be scheduled.  However, the "independent" files are
processed by an outside caller and so if the file ready for it turned
out to be invalid, it would see "nothing to be done" and wait an
extended period of time to try again.

The new version does the validity test during the initial check and
immediately advances to the next file if it detects a problem.  This
means there is always a file to process and never a significant delay
before trying the next one.

Bug: 760317,  780036 
Change-Id: I3fece9e41af3b8d29d0fa80b25141c00f9ae9db2
Reviewed-on: https://chromium-review.googlesource.com/804063
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521770}
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/components/metrics/file_metrics_provider.cc
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/components/metrics/file_metrics_provider.h
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/components/metrics/file_metrics_provider_unittest.cc
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/components/metrics/persistent_system_profile.cc
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/components/metrics/persistent_system_profile.h
[modify] https://crrev.com/514d9f3232687f8eb35ffa74993d1b5ad2a0b219/tools/metrics/histograms/enums.xml

Status: WontFix (was: Started)
Android files are not being uploaded because of the MetricsAndCrashSampling (stable) experiment that sends metrics on only 10% of devices.

Working as intended.

Sign in to add a comment