Committed interstitials: Retrieve HTML for supervised user interstitial instead of showing it |
|||||
Issue descriptionWhen committed interstitials are enabled, the SupervisedUserNavigationThrottle should retrieve the HTML contents of a supervised user interstitial instead of showing it. When committed interstitials are enabled, SupervisedUserNavigationObserver::OnRequestBlockedInternal should call a new method where it currently calls MaybeShowInterstitial. The new method should construct a SupervisedUserInterstitial, return the HTML contents, and destroy the interstitial. OnRequestBlockedInternal should take a blocking_page_ready callback, and OnRequestBlockedInternal should post a task to call that callback with the error page HTML. The blocking_page_ready callback should be passed from SupervisedUserNavigationThrottle::OnCheckDone to ShowInterstitial to ShowInterstitialAsync to OnRequestBlocked to OnRequestBlockedInternal. The callback should cancel the request and pass the provided HTML in the ThrottleCheckResult.
,
Nov 10 2017
,
Feb 18 2018
,
Feb 22 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5603f3479db8cdb9d7735f5300d4d73961f0772 commit b5603f3479db8cdb9d7735f5300d4d73961f0772 Author: Carlos IL <carlosil@chromium.org> Date: Thu Mar 01 18:12:32 2018 Added committed interstitials for Supervised User With committed interstitials on, supervised user interstitials are now displayed using the new codepath. For this, supervised user throttle was modified so it cancels the navigation with the interstitial HTML. Browser tests were also modified so they test the committed interstitials cases too. Will be done on future CLs (and disabled tests requiring this will be re-enabled): -Adding bindings for interstitials to request permission or go back. -Handling the case where the URL list changes and we have to block the current page. -Migrate everything off of base::Callback. Bug: 780032 Change-Id: I53af29c43cc9d905b078c308021562830c05f47e Reviewed-on: https://chromium-review.googlesource.com/940459 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#540210} [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_browsertest.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_interstitial.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_interstitial.h [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_navigation_observer.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_navigation_observer.h [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_navigation_throttle.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_navigation_throttle.h [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/common/chrome_features.cc [modify] https://crrev.com/b5603f3479db8cdb9d7735f5300d4d73961f0772/chrome/common/chrome_features.h
,
Mar 16 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by est...@chromium.org
, Oct 31 2017