We need to add UMA for BackgroundFetch before launch
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c commit 0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Apr 23 14:27:30 2018 [Background Fetch] Log general background fetch errors to UMA. Resolve UMA related TODOs in background_fetch_context.cc. Log the result of: - Registration creation - Registration deletion - Scheduler finishing TBR=avi@chromium.org Bug: 780025 Change-Id: Ia5898bf8d834863b48d4efb9a01fae0b1f91d9b3 Reviewed-on: https://chromium-review.googlesource.com/1015360 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#552691} [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/BUILD.gn [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/background_fetch/background_fetch_context.cc [add] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/background_fetch/background_fetch_metrics.cc [add] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/background_fetch/background_fetch_metrics.h [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/background_fetch/background_fetch_service_impl.cc [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/tools/metrics/histograms/enums.xml [modify] https://crrev.com/0f48a4a19a14ef359e1fb2636f15ec0c8ae8ab7c/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d581783b13e69c2c1d1cd71b538e9da225929c38 commit d581783b13e69c2c1d1cd71b538e9da225929c38 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Jul 17 15:41:35 2018 [Background Fetch] Add a FinishWithError abstract method for DatabaseTask. This method is meant to standardize how each database task executes its callback, and terminates the DatabaseTask. Most DatabaseTasks have an ad hoc way of doing this anyway. This also has the extra benefit of making reporting failures via UMA easier, since there will be one place to report from, rather than having it scattered all over the file. Also remove GetNumRequestsTask since it is not used anymore. TBR=avi@chromium.org Bug: 780025 Change-Id: I1d8793fd9a25ef52f19737958a65e0b0e774bde0 Reviewed-on: https://chromium-review.googlesource.com/1128079 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575651} [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/BUILD.gn [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/cleanup_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/cleanup_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/create_metadata_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/database_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/delete_registration_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/delete_registration_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_developer_ids_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_developer_ids_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_initialization_data_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_initialization_data_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_metadata_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_metadata_task.h [delete] https://crrev.com/36469a5c6e505e5d73a9ec443f6f6206ebd90e3a/content/browser/background_fetch/storage/get_num_requests_task.cc [delete] https://crrev.com/36469a5c6e505e5d73a9ec443f6f6206ebd90e3a/content/browser/background_fetch/storage/get_num_requests_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/mark_registration_for_deletion_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/mark_request_complete_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/mark_request_complete_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/start_next_pending_request_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/start_next_pending_request_task.h [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/update_registration_ui_task.cc [modify] https://crrev.com/d581783b13e69c2c1d1cd71b538e9da225929c38/content/browser/background_fetch/storage/update_registration_ui_task.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12da2b46f772b2bf29208cd0791a2439cb539f6f commit 12da2b46f772b2bf29208cd0791a2439cb539f6f Author: Rayan Kanso <rayankans@chromium.org> Date: Wed Aug 08 12:31:11 2018 [Background Fetch] Set up DatabaseTask UMA reporting Bug: 780025 Change-Id: I255b9a793b62c3688a7079d705759f437492f7c9 Reviewed-on: https://chromium-review.googlesource.com/1157010 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#581530} [modify] https://crrev.com/12da2b46f772b2bf29208cd0791a2439cb539f6f/content/browser/background_fetch/storage/database_task.cc [modify] https://crrev.com/12da2b46f772b2bf29208cd0791a2439cb539f6f/content/browser/background_fetch/storage/database_task.h [modify] https://crrev.com/12da2b46f772b2bf29208cd0791a2439cb539f6f/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e7082e5f8b1b43554d82966e30ccb134a31145b commit 4e7082e5f8b1b43554d82966e30ccb134a31145b Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Aug 10 13:09:31 2018 [Background Fetch] Log DatabaseTask storage errors to UMA This change reports storage errors for most database tasks. The ones not included are: - GetMetadataTask (this is always a subtask) - GetSettledFetchesTask & DeleteRegistrationTask The latter two are not included since they are being refactored in https://chromium-review.googlesource.com/c/chromium/src/+/1165149 which will make error reporting significantly easier. More extensive tests will be added once the last two tasks will also report errors, since it is hard to simulate CacheStorage errors in tasks other than those. Bug: 780025 Change-Id: I83cc076da67aadeed5c78de39bd6f8e250f011d9 Reviewed-on: https://chromium-review.googlesource.com/1165552 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582129} [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/cleanup_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/cleanup_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/create_metadata_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_developer_ids_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_developer_ids_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_initialization_data_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_initialization_data_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_registration_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/get_registration_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/mark_registration_for_deletion_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/mark_request_complete_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/mark_request_complete_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/start_next_pending_request_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/start_next_pending_request_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/update_registration_ui_task.cc [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/content/browser/background_fetch/storage/update_registration_ui_task.h [modify] https://crrev.com/4e7082e5f8b1b43554d82966e30ccb134a31145b/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e654048154cd7bcf4d5a09269fcf5710eb4ae07b commit e654048154cd7bcf4d5a09269fcf5710eb4ae07b Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Aug 14 08:48:57 2018 [Background Fetch] Add UMA collection for remaining Database Tasks. Bug: 780025 Change-Id: Ia8bb5d2667c4b9132cccbea5cfe5f6ce53e919a2 Reviewed-on: https://chromium-review.googlesource.com/1170829 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582868} [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/database_task.cc [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/database_task.h [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/delete_registration_task.cc [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/delete_registration_task.h [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/e654048154cd7bcf4d5a09269fcf5710eb4ae07b/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbf9df125b7d92b1cefac03b0cdee68395c98f95 commit bbf9df125b7d92b1cefac03b0cdee68395c98f95 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Aug 14 12:40:58 2018 [Background Fetch] Record the duration of web exposed methods. Record the duration of web exposed methods in BackgroundFetchManager using UMA. Bug: 780025 Change-Id: Ide4f4ce2f416f450475d4a75862b2a20ebee41fb Reviewed-on: https://chromium-review.googlesource.com/1170902 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582893} [modify] https://crrev.com/bbf9df125b7d92b1cefac03b0cdee68395c98f95/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc [modify] https://crrev.com/bbf9df125b7d92b1cefac03b0cdee68395c98f95/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.h [modify] https://crrev.com/bbf9df125b7d92b1cefac03b0cdee68395c98f95/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f6faa685311313af88b8d0807ef0c8f88382f56 commit 3f6faa685311313af88b8d0807ef0c8f88382f56 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Sep 04 19:34:09 2018 [Background Fetch] Record via UMA whether a fetch has duplicate requests Also reject the registration if that happens with a warning, and add a failing WPT test. Bug: 871174, 780025 Change-Id: Ibdcc49bc47ea959e0c255a48f5d090cb865a6e45 Reviewed-on: https://chromium-review.googlesource.com/1202262 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#588614} [add] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt [modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc [modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/128d3df790e2d0bb9d3ac740aa55667e5263bf23 commit 128d3df790e2d0bb9d3ac740aa55667e5263bf23 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Sep 07 17:34:08 2018 [Background Fetch] Record (UMA) the number of registrations on startup Bug: 780025 Change-Id: I916782c0e85e4a6fee87389f0b6909ec66eae18b Reviewed-on: https://chromium-review.googlesource.com/1210123 Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#589567} [modify] https://crrev.com/128d3df790e2d0bb9d3ac740aa55667e5263bf23/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/128d3df790e2d0bb9d3ac740aa55667e5263bf23/content/browser/background_fetch/background_fetch_metrics.cc [modify] https://crrev.com/128d3df790e2d0bb9d3ac740aa55667e5263bf23/content/browser/background_fetch/background_fetch_metrics.h [modify] https://crrev.com/128d3df790e2d0bb9d3ac740aa55667e5263bf23/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f commit 8ea27747b070e8bb15a2e62d1a8b266d37e1e69f Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Sep 28 15:21:06 2018 [Background Fetch] Measure Background Fetch feature usage TBR=dgozman@chromium.org Bug: 780025 Change-Id: I36e85988a6402bee5ca8fead28fddb64081c4133 Reviewed-on: https://chromium-review.googlesource.com/1246062 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595098} [modify] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.idl [modify] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [modify] https://crrev.com/8ea27747b070e8bb15a2e62d1a8b266d37e1e69f/tools/metrics/histograms/enums.xml
Comment 1 by delph...@chromium.org
, Jan 24 2018