New issue
Advanced search Search tips

Issue 780009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Chrome OS use Chrome JDA to decode jpeg.

Project Member Reported by mojahsu@chromium.org, Oct 31 2017

Issue description

The camera hal is in Chrome OS side.
We want to use the JDA in Chrome to help jpeg decode.
 
Cc: jcliang@chromium.org posciak@chromium.org henryhsu@chromium.org
Components: OS>Kernel>Camera
Labels: OS-Chrome
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a

commit 9725622913b418cdeeb8bd79e0cd2b3b54bcb82a
Author: Moja Hsu <mojahsu@chromium.org>
Date: Sat Jan 27 02:00:08 2018

Add JDA Mojo interface to camera dispatcher

The interface is used from chrome os camera hal for jpeg decoding. For
the compatibility issue between the Mojo versions of chrome os and
chrome. Shared buffer handle serialization is not supported between
the old version and the new version. We create a new DecodeWithFD in
GpuJpegDecodeAccelerator Mojo interface.

BUG= chromium:780009 
TEST=Run gpu_jpeg_decode_accelerator_unittest to check Mojo
interfaces.
Decode a real jpeg image from chrome os by the Mojo interfaces.
Run camera app.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8e7df9543dd532dc2457f334245593b6722a71fb
Reviewed-on: https://chromium-review.googlesource.com/670541
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532125}
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/BUILD.gn
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/android/video_capture_device_factory_android.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/camera_hal_dispatcher_impl.h
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/mojo/BUILD.gn
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/mojo/arc_camera3_service.mojom
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/video_capture_device_factory_chromeos.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/chromeos/video_capture_device_factory_chromeos.h
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/linux/video_capture_device_factory_linux.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/mac/video_capture_device_factory_mac.mm
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/video_capture_device_factory.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/video_capture_device_factory.h
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/video_capture_device_unittest.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/capture/video/win/video_capture_device_factory_win.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/mojo/interfaces/jpeg_decode_accelerator.mojom
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/mojo/services/mojo_jpeg_decode_accelerator_service.cc
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/media/mojo/services/mojo_jpeg_decode_accelerator_service.h
[modify] https://crrev.com/9725622913b418cdeeb8bd79e0cd2b3b54bcb82a/services/video_capture/device_factory_provider_impl.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a

commit 7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a
Author: Moja Hsu <mojahsu@chromium.org>
Date: Fri Mar 23 21:50:32 2018

common: Add jpeg_decode_accelerator library

This library uses the GpuJpegDecodeAccelerator in chrome by Mojo
interface.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libcamera_ipc
  cros-camera-libjda cros-camera-libjda_test
Run libjda_test
Built all camera3 modules and enabled it on samus.

Change-Id: I38c47f2d5b51dffc8bc27cfad61d64aa5cbc2c96
Reviewed-on: https://chromium-review.googlesource.com/721403
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/jda/geometry.mojom
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/jda/time.mojom
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/jda/jpeg_decode_accelerator.mojom
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/jpeg/jpeg_decode_accelerator_test.cc
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/include/cros-camera/camera_mojo_channel_manager.h
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/jpeg/jpeg_decode_accelerator_impl.cc
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/include/cros-camera/jpeg_decode_accelerator.h
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/Makefile
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/camera_mojo_channel_manager_impl.cc
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/camera_mojo_channel_manager_impl.h
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/jda/module.mk
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/jpeg/libjda.pc.template
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/jpeg/jpeg_decode_accelerator_impl.h
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/module.mk
[modify] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/mojo/cros_camera_service.mojom
[add] https://crrev.com/7477348b3f5adb0e4c3f6a4798282ae53d5d4d9a/common/jpeg/module.mk

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/a9ff782f6b9cde6805174c8ad279298bbbe3faa7

commit a9ff782f6b9cde6805174c8ad279298bbbe3faa7
Author: Moja Hsu <mojahsu@chromium.org>
Date: Fri Mar 23 21:50:31 2018

Add CameraMojoChannelManager in libcamera_ipc

It is in charge of initializing Mojo and provides APIs for camera
dispatcher or other mojo channels.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libcamera_ipc cros-camera-hal-usb
  cros-camera
Run camera app on samus.
CQ-DEPEND=CL:915484

Change-Id: I373451764ae710ed0ea98898fce0111ce309defc
Reviewed-on: https://chromium-review.googlesource.com/915745
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[add] https://crrev.com/a9ff782f6b9cde6805174c8ad279298bbbe3faa7/include/cros-camera/camera_mojo_channel_manager.h
[modify] https://crrev.com/a9ff782f6b9cde6805174c8ad279298bbbe3faa7/common/module.mk
[add] https://crrev.com/a9ff782f6b9cde6805174c8ad279298bbbe3faa7/common/camera_mojo_channel_manager_impl.cc
[add] https://crrev.com/a9ff782f6b9cde6805174c8ad279298bbbe3faa7/common/camera_mojo_channel_manager_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/9b727292c3d71340150097d1e0a28a82e5120510

commit 9b727292c3d71340150097d1e0a28a82e5120510
Author: Moja Hsu <mojahsu@chromium.org>
Date: Fri Mar 23 21:50:30 2018

Move ipc_util and all mojom files to the libcamera_ipc

Remove COMMON_OBJECTS and use libcamera_common instead.
Extract common mojo APIs from cros_camera_mojo_utils to ipc_util and
create a new library libcamera_ipc.
Move all mojom files into libcamera_ipc.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libcamera_common
  cros-camera-libcamera_ipc cros-camera-hal-usb
  cros-camera-libcab cros-camera-libcab-test cros-camera
  cros-camera-hal-intel-ipu3 cros-camera-hal-rockchip-isp1
Built all camera modules and run camera app on nautilus.
CQ-DEPEND=CL:915484

Change-Id: Ieb0efffcb9ecfa77b825c596b5feaf7ed438b0e0
Reviewed-on: https://chromium-review.googlesource.com/915881
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/camera_algorithm_callback_ops_impl.h
[delete] https://crrev.com/a3b7566664303b4163a6bfd015d0f634d3832951/common/mojo/module.mk
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/Makefile
[add] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/include/cros-camera/constants.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_hal_server_impl.h
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/include/cros-camera/ipc_util.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal/intel/psl/ipu3/Makefile.am.inc
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/camera3.mojom
[add] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/libcamera_ipc.pc.template
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/cros_camera_mojo_verifier.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/include/cros-camera/camera_buffer_manager.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera3_device_ops_delegate.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/cros_camera_mojo_utils.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/camera_algorithm_ops_impl.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal/rockchip/psl/rkisp1/Makefile.am.inc
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/camera_common.mojom
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal/usb/module.mk
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_hal_server_impl.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_module_callbacks_delegate.h
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/CameraMetadataTagsVerifier.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_hal_adapter.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera3_callback_ops_delegate.h
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/camera_metadata_tags.mojom
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/cros_camera_mojo_utils.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_device_adapter.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/module.mk
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_device_adapter.h
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/README.md
[add] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/algorithm/module.mk
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/module.mk
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/camera_metadata.mojom
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/ipc_util.cc
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/module.mk
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/hal_adapter/camera_module_delegate.h
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/cros_camera_service.mojom
[rename] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/mojo/algorithm/camera_algorithm.mojom
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/camera_algorithm_main.cc
[modify] https://crrev.com/9b727292c3d71340150097d1e0a28a82e5120510/common/libcab.pc.template

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a5efa7fe85cc351ea1fa3c3a70c78685904c136

commit 8a5efa7fe85cc351ea1fa3c3a70c78685904c136
Author: Moja Hsu <mojahsu@chromium.org>
Date: Fri Mar 23 21:50:33 2018

cros-camera-libjda(_test): Add initial ebuild

Add jpeg decode accelerator library to use GpuJpegDecodeAccelerator in
chrome.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libjda cros-camera-libjda_test
CQ-DEPEND=CL:721403
CQ-DEPEND=CL:746492

Change-Id: Ib65106cbe467af60485645907d7a55c00abaa139
Reviewed-on: https://chromium-review.googlesource.com/724562
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[add] https://crrev.com/8a5efa7fe85cc351ea1fa3c3a70c78685904c136/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[add] https://crrev.com/8a5efa7fe85cc351ea1fa3c3a70c78685904c136/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ad54991cc2d846f1644c5416216b0aa89bcad7c0

commit ad54991cc2d846f1644c5416216b0aa89bcad7c0
Author: Moja Hsu <mojahsu@chromium.org>
Date: Fri Mar 23 21:50:29 2018

Add libcamera_ipc and set up libcamera_common dependency

We remove the future.o and COMMON_OBJECTS for these modules.
Create a new library libcamera_ipc and use link libraries instead.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libcamera_common
  cros-camera-libcamera_ipc cros-camera-hal-usb
  cros-camera-libcab cros-camera
Built all camera modules and run camera app on samus.
CQ-DEPEND=CL:915745
CQ-DEPEND=CL:915881

Change-Id: Icf98c89ee9a9fe19e3fa1e5e85edfb50c33218ea
Reviewed-on: https://chromium-review.googlesource.com/915484
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/ad54991cc2d846f1644c5416216b0aa89bcad7c0/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/ad54991cc2d846f1644c5416216b0aa89bcad7c0/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/ad54991cc2d846f1644c5416216b0aa89bcad7c0/chromeos-base/cros-camera/cros-camera-9999.ebuild
[add] https://crrev.com/ad54991cc2d846f1644c5416216b0aa89bcad7c0/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild

Comment 8 by norvez@chromium.org, Mar 29 2018

It looks like there's a dependency problem in the ebuild, cros-camera-libcamera_ipc fails to emerge the first time, works the second time. See BuildPackages in https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/release/21423
#8: Just noticed your comment, filed  crbug.com/827103  to track.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/18f0fcb337a53d75ee2d09cb9a9f9db7364b8b61

commit 18f0fcb337a53d75ee2d09cb9a9f9db7364b8b61
Author: Moja Hsu <mojahsu@chromium.org>
Date: Thu Mar 29 12:38:18 2018

cros-camera-libcamera_ipc: Fix  dependency problem

Add libmojo and cros-camera-libcamera_metadata in DEPEND.

BUG= chromium:780009 
TEST=check if we can pass emerge-${BOARD} cros-camera-libcamera_ipc
first time.

Change-Id: I174dc65be01ef4208256f4aed5b9b1e2b7597909
Reviewed-on: https://chromium-review.googlesource.com/985594
Commit-Ready: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>

[modify] https://crrev.com/18f0fcb337a53d75ee2d09cb9a9f9db7364b8b61/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/266a72e3439d530f6be2009f7e8097456ff73bad

commit 266a72e3439d530f6be2009f7e8097456ff73bad
Author: Moja Hsu <mojahsu@chromium.org>
Date: Mon Apr 02 08:15:12 2018

libcab: Use camera mojo manager for mojo environment

Use camera mojo manager to init mojo and to get CameraAlgorithmOpsPtr.

BUG= chromium:780009 
TEST=emerge-${BOARD} cros-camera-libcamera_common
cros-camera-libcamera_ipc cros-camera-libcab cros-camera-libcab-test
cros-camera-hal-intel-ipu3
Run camera app on nautilus and check the USB camera and MIPI camera
work.
Run libcab-test

Change-Id: I1c4face23a3aa04c5d7dc3f8d8a1ea18d8a76359
Reviewed-on: https://chromium-review.googlesource.com/918604
Commit-Ready: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/camera_algorithm_bridge_impl.cc
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/camera_algorithm_bridge_impl.h
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/include/cros-camera/camera_mojo_channel_manager.h
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/ipc_util.cc
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/include/cros-camera/constants.h
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/camera_mojo_channel_manager_impl.cc
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/camera_mojo_channel_manager_impl.h
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/include/cros-camera/ipc_util.h
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/camera_algorithm_main.cc
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/hal_adapter/camera_hal_server_impl.cc
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/module.mk
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/libcab.pc.template
[modify] https://crrev.com/266a72e3439d530f6be2009f7e8097456ff73bad/common/libcamera_ipc.pc.template
[delete] https://crrev.com/3c1dae7c72703dd75fc4c7235a32662d363fbe8c/common/camera_algorithm_internal.h

Please give an update of this issue. When will this be enabled?

Comment 13 by mojahsu@google.com, Apr 24 2018

We only remain one CL now.
https://chromium-review.googlesource.com/c/chromiumos/platform/arc-camera/+/896911
It needs to be rebased and tested again. I am working on it.
JDA will be enabled soon. maybe this week.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/58b9cbc0871c2535d93ffa25e07c50329c55e5f5

commit 58b9cbc0871c2535d93ffa25e07c50329c55e5f5
Author: Moja Hsu <mojahsu@chromium.org>
Date: Mon Apr 30 07:40:08 2018

Integrate libjda and test mode to cros-camera-hal-usb

Add libjda dependency and install the constants.h.

BUG= chromium:780009 
CQ-DEPEND=CL:896911
TEST=emerge-${BOARD} cros-camera-hal-usb
Open camera app on nautilus and see the preview.

Change-Id: I3cd4e147885b31685487e3110c55f255229a193f
Reviewed-on: https://chromium-review.googlesource.com/1027293
Commit-Ready: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/58b9cbc0871c2535d93ffa25e07c50329c55e5f5/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/58b9cbc0871c2535d93ffa25e07c50329c55e5f5/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2

commit 4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2
Author: Moja Hsu <mojahsu@chromium.org>
Date: Mon Apr 30 07:40:08 2018

usb: Integrate hardware jpeg decode library

Use hardware jpeg decoder to decode jpeg.
Add test mode.

BUG= chromium:780009 
CQ-DEPEND=CL:958742
CQ-DEPEND=CL:1027293
TEST=emerge-${BOARD} cros-camera-hal-usb
FEATURES="test" emerge-samus cros-camera-hal-usb
Run Camera with and without JDA support and monitor the CPU time by
'top' command to see if CPU time is not worse with JDA.
Create test mode file to see if we enable the test mode flag.

Change-Id: I80c0737ec95f18a27c8e2ee8ed3fc12daf6bafc9
Reviewed-on: https://chromium-review.googlesource.com/896911
Commit-Ready: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/image_processor.h
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/libcamera_hal.gyp
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/unittest/image_processor_unittest.cc
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/test_pattern.cc
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/frame_buffer.cc
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/image_processor.cc
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/cached_frame.cc
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/test_pattern.h
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/include/cros-camera/constants.h
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/cached_frame.h
[modify] https://crrev.com/4ce1fef68d5b79bbf40244bcf4960a8c52bee9c2/hal/usb/frame_buffer.h

Status: Fixed (was: Assigned)

Sign in to add a comment