Failure to fill password on roonlabs.com |
||||
Issue descriptionM64dev. iPhone7 iOS11 Pre-req: Create an account on roonlabs.com and save the password - go to https://roonlabs.com. - in the hamburger menu in the page, tap "sign in" - tap in the email field - email of saved account appears in the keyboard accessory view - tap login in keyboard accessory view expected: - email and password fields are filled in actual: - nothing happens - keyboard disappears but no text inserted into either field.
,
Nov 14 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d812c8daeeb1491e51aa002c42730067349a9899 commit d812c8daeeb1491e51aa002c42730067349a9899 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Nov 15 17:29:39 2017 [IOS Password Manager] Using FieldIdentifier instead of field name. Currently name attribute is used for identifying fields, that's bad since pretty often name attribute is empty, so no chance to identify which fields to fill. Autofill has solution for this - __gCrWeb.common.getFieldIdentifier , which is similar to Blink nameForAutofill (actually even more robust). This patch implements using FieldIdentifier by Password Manager. Note: Function findMatchingPasswordForms is removed, since most of its code becomes obsolete with this patch and in other part has pretty significant duplication with fillPasswordFormWithData_ (in finding correct fields to detect). Bug: 780008 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4f11ee71a809723c8ce955c33a749c19cf34ca0f Reviewed-on: https://chromium-review.googlesource.com/769007 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516734} [modify] https://crrev.com/d812c8daeeb1491e51aa002c42730067349a9899/ios/chrome/browser/passwords/password_controller_js_unittest.mm [modify] https://crrev.com/d812c8daeeb1491e51aa002c42730067349a9899/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/d812c8daeeb1491e51aa002c42730067349a9899/ios/chrome/browser/passwords/resources/password_controller.js
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2183b6c54e93e62dcf30ef711098525e760f21b3 commit 2183b6c54e93e62dcf30ef711098525e760f21b3 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Wed Nov 22 17:01:15 2017 Improve non-http protocol support in removeQueryAndReferenceFromURL. This CL fixes bug 780008 , since a password form action from the bug report has form "javascript:*". Bug: 780008 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib39077ea2f34377108ea22acdf1a352be3ca28e3 Reviewed-on: https://chromium-review.googlesource.com/781862 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#518658} [modify] https://crrev.com/2183b6c54e93e62dcf30ef711098525e760f21b3/ios/web/web_state/js/common_js_unittest.mm [modify] https://crrev.com/2183b6c54e93e62dcf30ef711098525e760f21b3/ios/web/web_state/js/resources/common.js
,
Nov 22 2017
,
Jan 3 2018
Issue 568190 has been merged into this issue.
,
Jan 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sczs@chromium.org
, Nov 1 2017Status: Assigned (was: Untriaged)