New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779999 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unnecessary action is performed on Checkbox,when we hit enter to open'Learn more'link in 'Google Play Terms of Service' page of Playstore

Project Member Reported by rkalavakuntla@chromium.org, Oct 31 2017

Issue description

Chrome Version:64.0.3253.0/10082.0.0 dev channel Reks,Jerry
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user -> Launch chrome, Open Play store ->goto 'Google Play Terms of Service' page 
(2)Press Tab,till focus comes on 'Learn more' link, now hit Enter
(3)Close the sub-page that is opened and Observe the check-box(please refer video)

Actual:Unnecessary action is performed on Checkbox,when we hit enter to open'Learn more'link
Expected:Opening'Learn More' link shouldn't affect the Checkbox

This is a Regression issue as same is working fine in 62.0.3202.7/9901.3.0 dev channel Reks

Note:Issue is not seen in Linux,Windows OS

@khmel: Please confirm the issue
 
actual.mp4
9.1 MB View Download

Comment 1 by khmel@chromium.org, Nov 1 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1940e2b99aec124026fb61512418c99ef97e0c70

commit 1940e2b99aec124026fb61512418c99ef97e0c70
Author: khmel <khmel@google.com>
Date: Wed Nov 01 22:45:40 2017

arc: Prevent pressing Enter key on learn more toggles the checkbox.

This fixes bug when pressing Enter on learn more or settings link
also toggles the parent checkbox.

Bug:  779999 
Test: Manually on device. Clicking or pressing Enter or Space on the
      check box itself correctly toggles its state. Set focus on learn
      more and setting link. Clicking here or pressing the Enter
      activates help section and leaves current state of the checkbox.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d8aeecd4cf93207cb0251f6ea1088a13d637892
Reviewed-on: https://chromium-review.googlesource.com/749891
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513305}
[modify] https://crrev.com/1940e2b99aec124026fb61512418c99ef97e0c70/chrome/browser/resources/chromeos/arc_support/background.js

Comment 3 by khmel@chromium.org, Nov 1 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M64 dev build (10109.0.0, 64.0.3261.0).

Sign in to add a comment