New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779998 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird traces of cursor is seen on chrome://supervised-user-internals page while typing text.

Reported by db...@etouch.net, Oct 31 2017

Issue description

Chrome Version: 64.0.3253.3 Revision d5f4ba12a6c29b1b49da50663e51d7d6d2dad88e-refs/branch-heads/3253@{#5}(64bit)
OS: Mac(10.12.6,10.13.1)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://supervised-user-internals
(2) Type text in Try a URL text box and observe.

Actual: Weird traces of cursor is seen while typing text.

Expected: No such a traces should seen.

This is a regression issue, broken in 'M-64', below is bisect info:

Good Build: 64.0.3249.0
Bad Build: 64.0.3250.0

You are probably looking for a change made after 511471 (known good), but no later than 511472 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/a6ba03d35d8e187799e9e3b63c98eff490018b71..2cff87c380b22ade36aa4d85a6f983387559178c

Suspect: https://chromium.googlesource.com/chromium/src/+/2cff87c380b22ade36aa4d85a6f983387559178c

Note: Issue is not seen on Windows(7,8,10) and Linux(14.0LTS) 
 
Actual_Cursor.mov
2.5 MB Download
Expected_Cursor.mov
1.8 MB Download
Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.
I can reproduce on Mac, but not on Linux. It appears that the invalidation rect
is positioned wrong.
Cc: chrishtr@chromium.org
 Issue 782608  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b689930b0918450948c72447fec65f98e7eaa9a

commit 7b689930b0918450948c72447fec65f98e7eaa9a
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Nov 09 20:33:06 2017

Use BorderBoxRect when computing fragment paint offsets and
column fragmentation.

Visual rects may not have an origin at the (0, 0) point of the
object, which makes them inappropriate for paint offsets.
They are also not appropriate for fragmentation, because visual
overflow should extend beyond column bounds rather than
causing elements to paint into multiple fragments.

Note that fragment clips may still cut off visual overflow,
which is a bug, but now visual overflow will not extend across
columns.

Bug:  782608 ,  774699 ,  779998 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I23feab957c018c124f59b5b9b84644709c466e03
Reviewed-on: https://chromium-review.googlesource.com/759233
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515269}
[modify] https://crrev.com/7b689930b0918450948c72447fec65f98e7eaa9a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/7b689930b0918450948c72447fec65f98e7eaa9a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment