New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 779989 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 790979


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Double tap to either side to jump 10 seconds

Project Member Reported by beccahughes@chromium.org, Oct 31 2017

Issue description

Double tap to either side to jump 10 seconds
 
Status: Started (was: Assigned)
Cc: dah...@chromium.org amyroberts@chromium.org rachelis@chromium.org
My understanding is that we want to only do this on mobile and a double tap anywhere on desktop would go fullscreen instead as these are the common patterns in media controls. Do we all agree with this or should the double tap be done for all platforms?
Yes, I agree.
I agree as well, though I have started double clicking on videos now that I am used to it. 
Question, why 15 seconds? Why wouldn't we employ the same approach as YT? Double tap = 10 seconds every tap after adds 10 seconds?
Oh, I also thought we were doing double tap = 10. Is this not what we're implementing?
Description: Show this description
Summary: Media Controls: Double tap to either side to jump 10 seconds (was: Media Controls: Double tap to either side to jump 15 seconds)
It should be 10 seconds, my mistake!
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd37486c25aa78b96f844167e72eafd7d3990c5

commit 3dd37486c25aa78b96f844167e72eafd7d3990c5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Nov 13 14:57:07 2017

Media Controls: Refactor animation event listener

The animation event listener that was part of loading panel
will be useful for some other motion in the media controls so
this refactors it into a reusable component.

BUG= 779989 

Change-Id: I30f3b3aebe20bbeb9886c1c7d4b4e2f5174e4042
Reviewed-on: https://chromium-review.googlesource.com/763413
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515945}
[modify] https://crrev.com/3dd37486c25aa78b96f844167e72eafd7d3990c5/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[add] https://crrev.com/3dd37486c25aa78b96f844167e72eafd7d3990c5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlAnimationEventListener.cpp
[add] https://crrev.com/3dd37486c25aa78b96f844167e72eafd7d3990c5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlAnimationEventListener.h
[modify] https://crrev.com/3dd37486c25aa78b96f844167e72eafd7d3990c5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp
[modify] https://crrev.com/3dd37486c25aa78b96f844167e72eafd7d3990c5/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.h

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d8b790a16e4f60ddd1c28ed44228e91086ee228

commit 6d8b790a16e4f60ddd1c28ed44228e91086ee228
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Nov 20 16:17:31 2017

Media Controls: Double tap on either side to jump

Add double tap gesture recognition to MediaControlOverlayPlayButton so
it can detect double tap gestures on the side and jump accordingly. Adds
LayoutTests as a virtual test suite so they are tested with the modern
media controls flag on.

BUG= 779989 

Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677
Reviewed-on: https://chromium-review.googlesource.com/757138
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517839}
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/content/60_sec_video.webm
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/media/media-controls.js
[add] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/LayoutTests/virtual/modern-media-controls/media/controls/modern/README.txt
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/6d8b790a16e4f60ddd1c28ed44228e91086ee228/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4618948e7a3ccbacb5af68420eb27c0c16cbb25d

commit 4618948e7a3ccbacb5af68420eb27c0c16cbb25d
Author: Fernando Serboncini <fserb@chromium.org>
Date: Mon Nov 20 17:51:40 2017

Revert "Media Controls: Double tap on either side to jump"

This reverts commit 6d8b790a16e4f60ddd1c28ed44228e91086ee228.

Reason for revert: All those tests are failing on:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak

Sorry for the revert, but since they are new tests, please fix or mark them off for this bot before submitting.

Original change's description:
> Media Controls: Double tap on either side to jump
> 
> Add double tap gesture recognition to MediaControlOverlayPlayButton so
> it can detect double tap gestures on the side and jump accordingly. Adds
> LayoutTests as a virtual test suite so they are tested with the modern
> media controls flag on.
> 
> BUG= 779989 
> 
> Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677
> Reviewed-on: https://chromium-review.googlesource.com/757138
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517839}

TBR=jbroman@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: If381e9ad02782008083d78b24edfd92042f63818
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  779989 
Reviewed-on: https://chromium-review.googlesource.com/779226
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517855}
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/content/60_sec_video.webm
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/LayoutTests/media/media-controls.js
[delete] https://crrev.com/619bbcdf9dd379b0ff77da256fe25c90f2fac246/third_party/WebKit/LayoutTests/virtual/modern-media-controls/media/controls/modern/README.txt
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/4618948e7a3ccbacb5af68420eb27c0c16cbb25d/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Blockedon: 790979
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c186263631aa5acd49fda880c21630474e7dbf

commit f2c186263631aa5acd49fda880c21630474e7dbf
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Dec 06 18:16:11 2017

Reland: Media Controls: Double tap on either side to jump

Add double tap gesture recognition to MediaControlOverlayPlayButton so
it can detect double tap gestures on the side and jump accordingly. Adds
LayoutTests as a virtual test suite so they are tested with the modern
media controls flag on.

BUG= 779989 

TBR=jbroman@chromium.org

Change-Id: I2d6e3c79d5ca3b447eda70f35da3dd22283a14b3
Reviewed-on: https://chromium-review.googlesource.com/800150
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522139}
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/content/60_sec_video.webm
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/media/media-controls.js
[add] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/LayoutTests/virtual/modern-media-controls/media/controls/modern/README.txt
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/f2c186263631aa5acd49fda880c21630474e7dbf/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f81258f0351810250e0c48cd36a3ba7124a2fb6

commit 6f81258f0351810250e0c48cd36a3ba7124a2fb6
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Dec 07 01:37:05 2017

Revert "Reland: Media Controls: Double tap on either side to jump"

This reverts commit f2c186263631aa5acd49fda880c21630474e7dbf.

Reason for revert: virtual/modern-media-controls/media/controls/modern/slow-doubletap.html consistently times out on Win7 Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65034
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65035
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65036
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65037


Original change's description:
> Reland: Media Controls: Double tap on either side to jump
> 
> Add double tap gesture recognition to MediaControlOverlayPlayButton so
> it can detect double tap gestures on the side and jump accordingly. Adds
> LayoutTests as a virtual test suite so they are tested with the modern
> media controls flag on.
> 
> BUG= 779989 
> 
> TBR=jbroman@chromium.org
> 
> Change-Id: I2d6e3c79d5ca3b447eda70f35da3dd22283a14b3
> Reviewed-on: https://chromium-review.googlesource.com/800150
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522139}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: If52d84a124f06cfd44b0dcbfacc5470a6920d7dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  779989 
Reviewed-on: https://chromium-review.googlesource.com/813135
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522296}
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/content/60_sec_video.webm
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/LayoutTests/media/media-controls.js
[delete] https://crrev.com/7018710d0b28075e8b890828708775472ec62ff6/third_party/WebKit/LayoutTests/virtual/modern-media-controls/media/controls/modern/README.txt
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/6f81258f0351810250e0c48cd36a3ba7124a2fb6/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00cc2c33f434b92739f547e49564e00e2def68dc

commit 00cc2c33f434b92739f547e49564e00e2def68dc
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Dec 11 12:13:24 2017

Reland: Media Controls: Double tap on either side to jump

Add double tap gesture recognition to MediaControlOverlayPlayButton so
it can detect double tap gestures on the side and jump accordingly. Adds
LayoutTests as a virtual test suite so they are tested with the modern
media controls flag on.

This includes some updates to media-controls.js to harden the tests
which previously failed.

TBR=jbroman@chromium.org

BUG= 779989 

Change-Id: Icc0a408993519537f522bcc62eb6893952165006
Reviewed-on: https://chromium-review.googlesource.com/813776
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523078}
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/content/60_sec_video.webm
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-on-play-button.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-play-button.html
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/media/media-controls.js
[add] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/LayoutTests/virtual/modern-media-controls/media/controls/modern/README.txt
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/00cc2c33f434b92739f547e49564e00e2def68dc/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26e1e719f26a976672c64443e48a9470977e0c3

commit a26e1e719f26a976672c64443e48a9470977e0c3
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Dec 11 16:46:58 2017

Media Controls: Add double tap jump animation

Add a three arrows animation either side when the user double taps on
the video to jump. If the user jumps multiple times the animations will
show for how many times the user jumped.

BUG= 779989 

Change-Id: I528db78449e008075df8702304560a0126ec568b
Reviewed-on: https://chromium-review.googlesource.com/766435
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523110}
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[add] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElementTest.cpp
[add] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/resources/jump_image.svg
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
[modify] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[add] https://crrev.com/a26e1e719f26a976672c64443e48a9470977e0c3/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_overlay_play.css

Cc: steimel@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment