New issue
Advanced search Search tips

Issue 779978 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VirtualFileProvider should run with multiple threads

Project Member Reported by hashimoto@chromium.org, Oct 31 2017

Issue description

Currently, VirtualFileProvider is running with a single thread, but it may result in open() calls blocked by a long read() call.
This is problematic as blocking open() for long results in OpenFile() D-Bus method failing with the timeout.

FWIW VirtualFileProvider is running with a single thread because of a problem raised during the code review.
https://chrome-internal-review.googlesource.com/c/chromeos/cheets-scripts/+/420349#message-aa39dd8e276bdb1ae30b404d44603deb68f7d2b9
 
Chatted with nya@, we can solve the issue by throttling read requests when there are too many concurrent read requests running.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8182f27ed6915e120ec78d9a2cbe60f87ceaac

commit ec8182f27ed6915e120ec78d9a2cbe60f87ceaac
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Mon Nov 06 10:17:05 2017

arc: Fix to handle multiple file stream forwarders for the same ID

There can be multiple read requests on a single ID.

BUG= 779978 
TEST=unit_tests

Change-Id: I697e1fafe91373dfa87e924c803a80e64fe3b3e6
Reviewed-on: https://chromium-review.googlesource.com/749026
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514105}
[modify] https://crrev.com/ec8182f27ed6915e120ec78d9a2cbe60f87ceaac/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc
[modify] https://crrev.com/ec8182f27ed6915e120ec78d9a2cbe60f87ceaac/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.h
[modify] https://crrev.com/ec8182f27ed6915e120ec78d9a2cbe60f87ceaac/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a454cbdac75493212802fee3afb1f6b4b330cd92

commit a454cbdac75493212802fee3afb1f6b4b330cd92
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Wed Nov 08 11:12:28 2017

virtual-file-provider: Run tests

BUG= chromium:779978 
TEST=cros_workon_make --board=caroline --test virtual-file-provider
CQ-DEPEND=CL:749005

Change-Id: I6b9b582ddd03e13545208c6322b3a14eea400d2d
Reviewed-on: https://chromium-review.googlesource.com/749028
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a454cbdac75493212802fee3afb1f6b4b330cd92/chromeos-base/virtual-file-provider/virtual-file-provider-9999.ebuild

Labels: M-64
Status: Fixed (was: Started)

Sign in to add a comment