New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 779977 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Grey focus highlight is not seen on toggle button in chrome://settings/appearance.

Reported by rp...@etouch.net, Oct 31 2017 
Version: 64.0.3253.3 (32/64-bit)d5f4ba12a6c29b1b49da50663e51d7d6d2dad88e-refs/branch-heads/3253@{#5}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/appearance and click on 'Show home button' and click on 'Enter custom web address'
2. Now press 'Shift + Tab' key to bring focus on Toggle button and then close 'Show home button' by clicking it.
2. Now again click on 'Show home button' and then click on 'Enter custom web address' radio button and press 'Shift + Tab' key to bring focus on Toggle button,observe

Actual: Grey focus highlight is not seen on toggle button after pressing 'Shift + Tab' key
Expected: Grey focus highlight should be seen on toggle button after pressing 'Shift + Tab' key

This is regression issue, broken in ‘M 64’ and will soon update other info :
Good build:64.0.3240.0
Bad build: 64.0.3241.0
Actual_video.mp4
551 KB View Download
Expected_video.mp4
329 KB View Download

Comment 1 by rp...@etouch.net, Oct 31 2017

Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 64.0.3240.0 (Revision: 508893).
Bad build: 64.0.3241.0 (Revision: 508934).

You are probably looking for a change made after 508918 (known good), but no lat
er than 508919 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e0d7ed61b45554d5511a0e19d9ed69ed3717ac98..f423bc1ae49988cc5be11c16fd7fd137b84da587

From the CL above, assigning the issue to the concern owner 

@dpapad- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/f423bc1ae49988cc5be11c16fd7fd137b84da587

Thanks!

Comment 2 by dpa...@chromium.org, Oct 31 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6ecc0a3e5633d5b03fdfe2e9a8f94dff475d16

commit ad6ecc0a3e5633d5b03fdfe2e9a8f94dff475d16
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 01 18:56:16 2017

WebUI cr-toggle: Fix corner case leading to missing ripple.

It turns out that the usage of FocusOutlineManager was not necessary, and in
fact seems to be causing the corner case.

Bug:  779977 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id64851fd4bfadd13407a304cda11555db824d19a
Reviewed-on: https://chromium-review.googlesource.com/747485
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513199}
[modify] https://crrev.com/ad6ecc0a3e5633d5b03fdfe2e9a8f94dff475d16/ui/webui/resources/cr_elements/cr_toggle/compiled_resources2.gyp
[modify] https://crrev.com/ad6ecc0a3e5633d5b03fdfe2e9a8f94dff475d16/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[modify] https://crrev.com/ad6ecc0a3e5633d5b03fdfe2e9a8f94dff475d16/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js

Comment 4 by dpa...@chromium.org, Nov 1 2017

Status: Fixed (was: Started)

Comment 5 by rp...@etouch.net, Nov 2 2017

Labels: TE-Verified-64.0.3256.0 TE-Verified-M64
Note : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) with latest canary chrome version : 64.0.3256.0 and the issue is not reproduced.Kindly refer attached screen cast for reference.
Actual_video.mp4
394 KB View Download
►

Sign in to add a comment