New issue
Advanced search Search tips

Issue 779973 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Flaky crashes of WebViewTests/WebViewTest.Interstitial* on Win dbg bots

Project Member Reported by shimazu@chromium.org, Oct 31 2017

Issue description

Some of WebViewTests/WebViewTest.Interstitial* tests are crashing on Win dbg bots.

WebViewTests/WebViewTest.InterstitialPage/1
WebViewTests/WebViewTest.InterstitialPageDetach/0
WebViewTests/WebViewTest.InterstitialPageDetach/1
WebViewTests/WebViewTest.InterstitialPageFocusedWidget/1
WebViewTests/WebViewTest.InterstitialPageRouteEvents/1
WebViewTests/WebViewTest.InterstitialTeardown/0
WebViewTests/WebViewTest.InterstitialTeardown/1

See the flakiness dashboard for detail:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebViewTests/WebViewTest.Interstitial

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f08bb0b5cba2be3c04ece1348af9d39f646cf58

commit 3f08bb0b5cba2be3c04ece1348af9d39f646cf58
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Oct 31 09:48:33 2017

Disabled WebViewTests/WebViewTest.Interstitial* on Win dbg

TBR=lazyboy@chromium.org

Bug: 779973
Change-Id: I63f4805d5d4907b4339c83b6cd310447d40526e0
Reviewed-on: https://chromium-review.googlesource.com/746601
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512792}
[modify] https://crrev.com/3f08bb0b5cba2be3c04ece1348af9d39f646cf58/chrome/browser/apps/guest_view/web_view_browsertest.cc

Owner: wjmaclean@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc430dd4978bdc98de8d1be93d42ee09147cb42

commit bcc430dd4978bdc98de8d1be93d42ee09147cb42
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Tue Oct 31 20:13:36 2017

Disable WebViewTests/WebViewTest.Interstitial* on Win dbg

Follow-on to https://crrev.com/c/746601 which seems to have gotten the
dbg condition backwards.

TBR=lazyboy@chromium.org

Bug: 779973
Change-Id: Ifd36b0644bbd209e901841b63c78403ee4631685
Reviewed-on: https://chromium-review.googlesource.com/747627
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512927}
[modify] https://crrev.com/bcc430dd4978bdc98de8d1be93d42ee09147cb42/chrome/browser/apps/guest_view/web_view_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69651b36ae7c667870d6772b69aaade716cf997e

commit 69651b36ae7c667870d6772b69aaade716cf997e
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Nov 01 05:42:31 2017

Disable several WebViewTests correctly

This is following-on to crrev.com/c/746601 and crrev.com/c/747627. The original
patch to disable the tests is missing to add MAYBE_ prefixes for each test.

TBR=lazyboy@chromium.org

Bug: 779973
Change-Id: Ib6a86f61972436034c84694ce87ebab763db7f89
Reviewed-on: https://chromium-review.googlesource.com/748402
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513084}
[modify] https://crrev.com/69651b36ae7c667870d6772b69aaade716cf997e/chrome/browser/apps/guest_view/web_view_browsertest.cc

Comment 5 by meade@chromium.org, Nov 6 2017

Labels: -Sheriff-Chromium
I don't see this problem on SoM any more, removing sheriff label.
Cc: inglorion@chromium.org

Sign in to add a comment