libmojo: allow building shared library |
||||
Issue descriptionCurrently the pkgconfig file of the libmojo-395517 package advertises libs flags that links against the .pie object. This causes problems when we want to build shared library that depends on libmojo. We should change the pkgconfig file to advertise .pie object as libs flags.
,
Oct 31 2017
Ah, yes. That was a typo. I meant .pic for libs flags.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/08eb2c37ac91377aa5c59586820c9fdc10e66793 commit 08eb2c37ac91377aa5c59586820c9fdc10e66793 Author: Ricky Liang <jcliang@chromium.org> Date: Tue Oct 31 14:44:08 2017 libmojo: modify pkg-config libs flags to link against pic object To build shared library that depends on libmojo, we need to change the libs flags in limojo's pkgconfig file to link against pic object. BUG= chromium:779971 TEST=Build libmojo and verify in board sysroot that the installed libmojo-395517.pc has .pic in libs flags. Change-Id: I0fcf87643acfec6b53a01c3ac88604760bcd622b Reviewed-on: https://chromium-review.googlesource.com/746492 Commit-Ready: Ricky Liang <jcliang@chromium.org> Tested-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> [rename] https://crrev.com/08eb2c37ac91377aa5c59586820c9fdc10e66793/chromeos-base/libmojo/libmojo-395517-r2.ebuild [add] https://crrev.com/08eb2c37ac91377aa5c59586820c9fdc10e66793/chromeos-base/libmojo/files/libmojo-395517-Link-against-pic-object-instead-of-pie-object.patch [modify] https://crrev.com/08eb2c37ac91377aa5c59586820c9fdc10e66793/chromeos-base/libmojo/libmojo-395517.ebuild
,
Nov 2 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hywu@chromium.org
, Oct 31 2017